[app][inetsrv] use correct buffer size in tcp_read#517
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR fixes a length argument bug in the app/inetsrv echo server’s read loop, ensuring tcp_read() is passed the actual allocated buffer capacity rather than the size of a pointer.
Changes:
- Replace
sizeof(buf)withECHO_BUFSIZEwhen callingtcp_read()inecho_worker().
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix the buffer size argument passed to
tcp_read()inapp/inetsrv/inetsrv.c.The previous code used
sizeof(buf), which evaluates to the size of thepointer rather than the intended buffer capacity. Use
ECHO_BUFSIZEinstead.Testing
make qemu-virt-arm64-test