feat: add wrapper request DTOs for chaos experiment list/save#60
Open
alswjdghks wants to merge 1 commit into
Open
feat: add wrapper request DTOs for chaos experiment list/save#60alswjdghks wants to merge 1 commit into
alswjdghks wants to merge 1 commit into
Conversation
Introduce ChaosExperimentListRequest and ChaosExperimentSaveRequest following the existing UserCreateRequest builder pattern, and update LitmusClient.listExperiment / LitmusClient.saveChaosExperiment to accept these wrappers directly. The DTOs were renamed from the names proposed in the issue (ListExperimentRequest / SaveChaosExperimentRequest) to avoid simple-name collisions with the DGS-generated input types of the same name in io.litmuschaos.generated.types. Refs litmuschaos#59 Signed-off-by: 민정환 <jerrymin1221@naver.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ChaosExperimentListRequestandChaosExperimentSaveRequestfollowing the existingUserCreateRequestbuilder pattern.LitmusClient.listExperimentandLitmusClient.saveChaosExperimentto accept the new wrappers directly.ListExperimentRequest/SaveChaosExperimentRequest) to avoid simple-name collisions with the DGS-generated input types of the same name inio.litmuschaos.generated.types.This takes the (a) replace-signatures path from the issue's open question. Happy to switch to (b) overloads if maintainers prefer.
Test plan
./mvnw clean generate-sources test-compile— BUILD SUCCESS (JDK 21, target 17)LitmusClientTestrequires a running LitmusChaos backend, not verified locallyRelated
Closes #59