Skip to content

Pad single digit numbers with zeros to a width of two - #10

Open
paultcochrane wants to merge 1 commit into
lithium:masterfrom
paultcochrane:pr/standard_time_format
Open

Pad single digit numbers with zeros to a width of two#10
paultcochrane wants to merge 1 commit into
lithium:masterfrom
paultcochrane:pr/standard_time_format

Conversation

@paultcochrane

Copy link
Copy Markdown

This change gives the time display a more standardised/common look. When
using the app, I was surprised to see the seconds display go down to a
single digit and the display not to be padded by a zero, as this is not the
behaviour a standard digital clock has. This is the reasoning behind this
commit: to reduce surprise to users.

This change gives the time display a more standardised/common look.  When
using the app, I was surprised to see the seconds display go down to a
single digit and the display not to be padded by a zero, as this is not the
behaviour a standard digital clock has.  This is the reasoning behind this
commit: to reduce surprise to users.
@surr

surr commented Apr 18, 2015

Copy link
Copy Markdown

There is a different issue with printing time, that could be fixed here too.
Negative times are computed and printed wrong.
I suppose, that Math.abs should be applied directly to left variable before computation of min and sec. So the time line would be '0:01' -> '0:00' -> '-0:00' -> '-0:01' and so on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants