Pad single digit numbers with zeros to a width of two - #10
Open
paultcochrane wants to merge 1 commit into
Open
Conversation
This change gives the time display a more standardised/common look. When using the app, I was surprised to see the seconds display go down to a single digit and the display not to be padded by a zero, as this is not the behaviour a standard digital clock has. This is the reasoning behind this commit: to reduce surprise to users.
|
There is a different issue with printing time, that could be fixed here too. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change gives the time display a more standardised/common look. When
using the app, I was surprised to see the seconds display go down to a
single digit and the display not to be padded by a zero, as this is not the
behaviour a standard digital clock has. This is the reasoning behind this
commit: to reduce surprise to users.