Skip to content

fix(build): make rule pack discovery portable #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
intellinfra-dev merged 1 commit into from
Aug 24, 2026
Merged

fix(build): make rule pack discovery portable #7

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,10 @@ KUBEATLAS ?= kubeatlas
# When PACK= is set the targets operate on a single directory; with
# no PACK we walk every top-level dir that has a metadata.yaml.
ifeq ($(PACK),)
PACK_DIRS := $(shell find . -mindepth 2 -maxdepth 2 -name metadata.yaml -printf '%h\n' | sort)
# GNU make's wildcard functions behave consistently on Linux and macOS.
# Avoid GNU find-only flags such as -printf: BSD find rejects them and used to
# leave PACK_DIRS empty while the targets still reported success.
PACK_DIRS := $(patsubst %/metadata.yaml,%,$(wildcard */metadata.yaml))
else
PACK_DIRS := $(PACK)
endif
Expand All @@ -41,7 +44,7 @@ OPA_IGNORE_FLAGS := --ignore '*.yaml' --ignore '*.yml'

check: ## opa check: syntax + reference validation.
@if [ -z "$(PACK_DIRS)" ]; then \
echo "no packs found"; exit 0; \
echo "no packs found" >&2; exit 1; \
fi; \
for d in $(PACK_DIRS); do \
echo "==> opa check $$d"; \
Expand All @@ -50,7 +53,7 @@ check: ## opa check: syntax + reference validation.

test: ## opa test: per-pack unit tests under tests/.
@if [ -z "$(PACK_DIRS)" ]; then \
echo "no packs found"; exit 0; \
echo "no packs found" >&2; exit 1; \
fi; \
for d in $(PACK_DIRS); do \
echo "==> opa test $$d"; \
Expand All @@ -59,7 +62,7 @@ test: ## opa test: per-pack unit tests under tests/.

integration: ## kubeatlas rules-test: load + evaluate against samples/.
@if [ -z "$(PACK_DIRS)" ]; then \
echo "no packs found"; exit 0; \
echo "no packs found" >&2; exit 1; \
fi; \
for d in $(PACK_DIRS); do \
if [ ! -d $$d/samples ]; then \
Expand Down