fix: move inline comments above env vars in .env.local.example - #251
Open
tturnerdev wants to merge 1 commit into
Open
fix: move inline comments above env vars in .env.local.example#251tturnerdev wants to merge 1 commit into
tturnerdev wants to merge 1 commit into
Conversation
tturnerdev
force-pushed
the
fix/env-inline-comments
branch
from
April 28, 2026 03:23
7f7d760 to
65da09d
Compare
Inline comments after `=` in .env files are not treated as comments by most parsers — the text after the value (including the `#`) is parsed as part of the value itself. This caused SMTP authentication failures with Mailpit because `EMAIL_SMTP_USER` resolved to the comment string rather than an empty value, triggering an unwanted `smtp.login()` call. Move all inline comments to the line above their respective variables. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
tturnerdev
force-pushed
the
fix/env-inline-comments
branch
from
April 28, 2026 03:27
65da09d to
6ad281e
Compare
|
Contributor
Author
|
PR made with help of AI; fully reviewed and verified by me. Some additional details:
Application environment details:
Otherwise, fully stock set up. The SMTP errors began immediately after adding Before this, emails were not working at all and I had to copy the sign-up URL token directly from the logs (or edit the user in db to set to "verified"). After this change, I now see outgoing emails in Mailpit as expected. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Summary
=in.envfiles are parsed as part of the value by most env parsers (python-dotenv, shellsource, etc.)EMAIL_SMTP_USERto resolve to# Mailpit doesn't require auth, leave empty for devinstead of an empty stringsmtp.login()against Mailpit, which doesn't support SMTP AUTH without TLS, resulting in:EmailConnectionError: SMTP connection error: The SMTP AUTH extension is not supported by this serverTest plan
.env.local.exampleto.env🤖 Generated with Claude Code