feat(revenue): add batchAccrueVaultFees to RevenueCollector - #223
Open
razww wants to merge 1 commit into
Open
Conversation
Add BOT-gated batchAccrueVaultFees/accrueVaultFee methods that trigger Moolah vault fee accrual via a zero-asset deposit(0, address(this)). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Pull Request ReviewThis Solidity PR adds BOT-gated single and batch functions to trigger Moolah vault fee accrual through zero-asset deposits, along with a corresponding event and internal helper. It also adds Foundry tests covering role enforcement, successful calls, receiver and amount parameters, and batch-length validation. Sensitive ContentNo sensitive content detected. Security IssuesNo serious security issues detected. Generated by Hashdit Bot. This tool can absolutely NOT replace manual audits. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a BOT-gated way for the
RevenueCollectorto trigger fee accrual on Moolah vaults via a zero-assetdeposit(0, address(this))call. A zero-asset deposit mints no shares but runs the vault's_accrueFee()logic, realizing accrued fees to the vault's fee recipient.Changes
batchAccrueVaultFees(address[] calldata vaults)— validates0 < length <= MAX_LENGTH(30) and accrues each vault.accrueVaultFee(address vault)— single-vault variant._accrueVaultFeeinternal helper +VaultFeeAccrued(address indexed vault)event.onlyRole(BOT), consistent with the existing DEX/liquidation fee methods.Notes
deposit(0, ...)inMoolahVaultgates the receiver on the vault whitelist (when non-empty). Since the receiver isaddress(this), the RevenueCollector address must be whitelisted on any vault that enforces a whitelist. Shareholding is irrelevant._supplyMoolah(0)is a no-op and_mint(receiver, 0)does not revert.Testing
forge test --mc RevenueCollectorTest— 8 passed (3 new:test_batchAccrueVaultFees,test_accrueVaultFee,test_batchAccrueVaultFees_invalidLength).forge buildclean; prettier passes.🤖 Generated with Claude Code