chore(moolah-vault): increase MAX_QUEUE_LENGTH from 100 to 1000 - #222
Open
razww wants to merge 2 commits into
Open
chore(moolah-vault): increase MAX_QUEUE_LENGTH from 100 to 1000#222razww wants to merge 2 commits into
razww wants to merge 2 commits into
Conversation
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Pull Request ReviewThis Solidity PR increases Sensitive ContentNo sensitive content detected. Security IssuesNo serious security issues detected. Generated by Hashdit Bot. This tool can absolutely NOT replace manual audits. |
Decouple NB_MARKETS from ConstantsLib.MAX_QUEUE_LENGTH so the shared vault setUp no longer creates 1001 markets per test. Rewrite testAcceptCapMaxQueueLengthExceeded to create markets on demand and enable them via direct setCap (O(n)) instead of the supply-queue-rebuilding helper (O(n^2)), which blew up at MAX_QUEUE_LENGTH=1000. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Pull Request ReviewThis Solidity PR increases Sensitive ContentNo sensitive content detected. Security IssuesNo serious security issues detected. Generated by Hashdit Bot. This tool can absolutely NOT replace manual audits. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Increases the hardcoded maximum supply/withdraw queue length in
MoolahVaultfrom 100 to 1000.src/moolah-vault/libraries/ConstantsLib.sol:MAX_QUEUE_LENGTH100→1000This constant caps both the supply and withdraw queues, enforced in:
MoolahVault.setSupplyQueue(MoolahVault.sol:245)MoolahVault.updateWithdrawQueue(MoolahVault.sol:643)Both now allow up to 1000 markets in the queue.
Testing
forge buildpasses.🤖 Generated with Claude Code