chore: add BSC Testnet upgrade script for ListaRevenueDistributor - #115
Open
LuckyTian1725 wants to merge 1 commit into
Open
chore: add BSC Testnet upgrade script for ListaRevenueDistributor#115LuckyTian1725 wants to merge 1 commit into
LuckyTian1725 wants to merge 1 commit into
Conversation
Pull Request ReviewThis PR adds a new Foundry script to deploy a fresh Sensitive ContentBlockchain Address:
Security IssuesNo serious security issues detected. Generated by Hashdit Bot. This tool can absolutely NOT replace manual audits. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add a Foundry script to deploy and upgrade
ListaRevenueDistributoron BSC Testnet. Used for testnet verification of the Cross-chain Parity Upgrade (salt 146, checklist items 1.9–1.12).The script deploys a new implementation, calls
ProxyAdmin.upgradeAndCall(), then verifies theEMERGENCY_WITHDRAWERrole is accessible and the ERC1967 implementation slot was updated.Change Type
Contracts Changed
scripts/foundry/dao/bsc_upgrade_revenueDistributor.solKey Changes
forge createequivalent vianew ListaRevenueDistributor()usingPRIVATE_KEY_TESTNETProxyAdmin.upgradeAndCall(proxy, newImpl, "")usingPRIVATE_KEY_PROXY_ADMINEMERGENCY_WITHDRAWERrole accessible + ERC1967 impl slot updatedTestnet Addresses
0xe36857af784fB2B8cFA22481b51Fa0c99D13fF200x529D1D9eB9D2D664148be1AE15281521c5d498F30xF95420437F981F806499322679967a5e7E8A6268Verification
Risk Assessment