Skip to content

chore: add BSC Testnet upgrade script for ListaRevenueDistributor - #115

Open
LuckyTian1725 wants to merge 1 commit into
masterfrom
chore/testnet-upgrade-revdistributor
Open

chore: add BSC Testnet upgrade script for ListaRevenueDistributor#115
LuckyTian1725 wants to merge 1 commit into
masterfrom
chore/testnet-upgrade-revdistributor

Conversation

@LuckyTian1725

@LuckyTian1725 LuckyTian1725 commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

Summary

Add a Foundry script to deploy and upgrade ListaRevenueDistributor on BSC Testnet. Used for testnet verification of the Cross-chain Parity Upgrade (salt 146, checklist items 1.9–1.12).

The script deploys a new implementation, calls ProxyAdmin.upgradeAndCall(), then verifies the EMERGENCY_WITHDRAWER role is accessible and the ERC1967 implementation slot was updated.

Change Type

  • Bug fix
  • Configuration change (existing contract)
  • Deploy script (new)
  • New contract
  • Test (new)
  • Upgrade (existing proxy)

Contracts Changed

Contract File Type Description
Upgrade script (Foundry) scripts/foundry/dao/bsc_upgrade_revenueDistributor.sol new BSC Testnet deploy + upgrade script for ListaRevenueDistributor

Key Changes

Area Detail
Deploy new impl forge create equivalent via new ListaRevenueDistributor() using PRIVATE_KEY_TESTNET
Upgrade proxy ProxyAdmin.upgradeAndCall(proxy, newImpl, "") using PRIVATE_KEY_PROXY_ADMIN
Verify Checks EMERGENCY_WITHDRAWER role accessible + ERC1967 impl slot updated

Testnet Addresses

Item Address
Proxy 0xe36857af784fB2B8cFA22481b51Fa0c99D13fF20
ProxyAdmin 0x529D1D9eB9D2D664148be1AE15281521c5d498F3
New Impl (deployed) 0xF95420437F981F806499322679967a5e7E8A6268

Verification

source .env && forge script scripts/foundry/dao/bsc_upgrade_revenueDistributor.sol \
  --rpc-url https://bsc-testnet.nodereal.io/v1/<KEY> \
  --broadcast --skip "contracts/oft/**" --skip "contracts/token/**" -vvvv

--skip flags needed: OFT contracts import newer LayerZero packages not installed in this repo.

Risk Assessment

Area Risk Note
Mainnet impact None Script targets BSC Testnet only
Storage N/A Script only, no contract changes
Runtime None No modifications to existing contracts

@hashdit-bot

hashdit-bot Bot commented Jul 15, 2026

Copy link
Copy Markdown

Pull Request Review

This PR adds a new Foundry script to deploy a fresh ListaRevenueDistributor implementation on BSC Testnet and upgrade an existing proxy through ProxyAdmin.upgradeAndCall. The script uses two environment-provided private keys (deployer and proxy admin owner), then performs post-upgrade checks for EMERGENCY_WITHDRAWER accessibility and ERC1967 implementation-slot correctness. No production contract logic is modified in this diff; it is operational upgrade tooling.

Sensitive Content

Blockchain Address:

  • 0xe36857af784fB2B8cFA22481b51Fa0c99D13fF20 (EVM address, proxy) in scripts/foundry/dao/bsc_upgrade_revenueDistributor.sol
  • 0x529D1D9eB9D2D664148be1AE15281521c5d498F3 (EVM address, ProxyAdmin) in scripts/foundry/dao/bsc_upgrade_revenueDistributor.sol

Security Issues

No serious security issues detected.


Generated by Hashdit Bot. This tool can absolutely NOT replace manual audits.

@razww razww left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants