Skip to content

Rework API to make required/core parameters positional#34

Merged
zanerock merged 3 commits into
liquid-labs:mainfrom
zanerock:work-liquid-labs/semver-plus/33
Oct 12, 2025
Merged

Rework API to make required/core parameters positional#34
zanerock merged 3 commits into
liquid-labs:mainfrom
zanerock:work-liquid-labs/semver-plus/33

Conversation

@zanerock

@zanerock zanerock commented Oct 12, 2025

Copy link
Copy Markdown
Member

Pull request to resolve #33

Submitted by: zanerock

Instructions

Review all code changes. Verify the submitter attestations belowe, checking off each statement to indicate that you have reviewed the statement and it is true to the best of your knowledge. If you do not agree with or are unsure of a statement, then add a comment describing your questions or concerns and contact the submitter @zanerock for clarification.

QA files

Submitter attestations

To be verified by reviewer.

  • Do the changes implement all concrete TODOs in the change ticket? y (WORK_SUBMIT_IMPLEMENT_ALL_TODOS=true)
  • Are there other changes not described in the original work description? n (WORK_SUBMIT_HAS_ADDITIONAL_CHANGES=false)
  • Do the changes add or involve connections, authentication, or queries to a database or any third-party service? n (WORK_SUBMIT_THIRD_PARTY_SERVICES_MODIFIED=false)
  • Has all debug, hard coded test data, and hard coded authentication data been removed? y (WORK_SUBMIT_DEBUG_REMOVED=true)
  • I have reviewed and verified the above are true to the best of my knowledge.

@zanerock zanerock added this to the 1.0.0-beta milestone Oct 12, 2025
@zanerock zanerock self-assigned this Oct 12, 2025
@zanerock zanerock merged commit 46ae5b4 into liquid-labs:main Oct 12, 2025
10 checks passed
@zanerock zanerock deleted the work-liquid-labs/semver-plus/33 branch October 12, 2025 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Rework API to make required/core parameters positional

1 participant