ci: Keep GITHUB_TOKEN off disk when checking out PR code - #673
ci: Keep GITHUB_TOKEN off disk when checking out PR code #673mariiapisarenko wants to merge 1 commit into
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe workflow disables persisted Git credentials in the build and unit-test checkout steps. Comments document the defense-in-depth rationale. ChangesCheckout credential handling
Estimated code review effort: 1 (Trivial) | ~5 minutes Mergeability Score: ⚪ Minimal · up to The workflow now avoids persisting GITHUB_TOKEN credentials during fork-controlled checkouts, with no actionable merge-blocking risk remaining after normal checks. Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
What
Adds
persist-credentials: falseto both PR-head checkouts inos-extension-test.yml. These check out fork-controlled code in a job that holds vault secrets, andactions/checkoutotherwise leaves the token in.git/configwhere the Maven build could read it.Why
Part of TECHOPS-525.
Minimal, non-breaking defense-in-depth behind the caller's environment gate.