Update to v0.4.9#105
Open
lipelopesoliveira wants to merge 27 commits into
Open
Conversation
…te documentation.
…and Qst computations
…tomLennardJones and CustomGNP calculators
…in library for atom overlap checks
…aals overlap detection in GCMC class
…improved performance
…urn a numpy array
…ilibration method
…d improve readability
…for standard deviation calculation
… Vesin package for improved performance
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Description 📝
Changes Proposed 🔧
New Features 🎉
Enhanced ✨
vesinlibrary to check for atom overlaps during the insertion of adsorbates in the GCMC and Widom simulations. Thevesinlibrary provides a more efficient method for calculating distances, prividing around 10x speedup in the overlap checking process. From the practical point of view, this change should provide only a minor speedup in the overall simulation time, as this process took only 30 ms on average for 2000 atoms, and now takes only 3 ms. However, this change improves the overall efficiency of the code and reduces the computational overhead associated with overlap checking.Fixed 🐛
shiftedparameter in theCustomLennardJonesandCustomGNPcalculators is set toFalse. This change ensures that the Lennard-Jones and GNP potentials are not shifted by default, which may be more appropriate for certain simulations. Users can still set this parameter toTrueif they wish to apply a shift to the potential.Documentation 📖
Removed 🗑️
Related Issues 📎
Fixes # <issue_number>
Closes # <issue_number>
Before submitting 📌
section of the
CONTRIBUTINGdocs.Writing docstrings section of the
CONTRIBUTINGdocs.Testing Instructions 🧪
Additional Notes 💬