fix: 补全 applyUserMessageLayoutState 缺失的 import,修复保存全局设置报错 - #184
Merged
Conversation
Contributor
Author
|
本 PR 报的 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
问题
在全局设置中点击「保存」时,必现如下报错(设置本身已写入,但保存后的界面即时应用被中断):
根因
2a259e39f在modules/renderer/mainChatSettingsPresentationOwner.js的applyUserChatBubbleUiState()中新增了对applyUserMessageLayoutState()的调用,但该文件没有任何 import 语句,模块作用域内不存在此标识符,保存设置后刷新用户气泡布局时抛出ReferenceError。修复
补全缺失的 import:
domBuilder.js为零依赖的叶子模块,不存在循环引用风险。验证
node --check通过;