global: Don't create a scope for D-Bus activated applications - #13926
Open
Fantu wants to merge 1 commit into
Open
global: Don't create a scope for D-Bus activated applications#13926Fantu wants to merge 1 commit into
Fantu wants to merge 1 commit into
Conversation
When an application is started through D-Bus activation the launch context reports pid 0, since the process is spawned by the bus, not by us. Passing that on to gnome_start_systemd_scope() creates an empty app-cinnamon-<id>-0.scope that stays active forever, and is pointless anyway: the activated service already runs in its own unit. gnome-shell has the same guard for the same reason. This has no visible effect today only because the scope is never created; it does as soon as that is fixed in cinnamon-desktop. Assisted-by: Claude Code:claude-opus-5
This was referenced Aug 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When an application is started through D-Bus activation, the launch context reports pid 0: the process is spawned by the bus, not by us. Passing that on to
gnome_start_systemd_scope()creates an empty scope that never has any process in it and stays active forever:It is also pointless, since a D-Bus activated service already runs in its own unit. gnome-shell has the same guard in
shell_global_app_launched_cb()for the same reason.This has no visible effect today, only because
gnome_start_systemd_scope()never gets far enough to create anything — see linuxmint/cinnamon-desktop#275. It does as soon as that is fixed, which is why it is worth landing the two together.Testing
Mint 23, Cinnamon 6.7.4 with the cinnamon-desktop fix applied. Launching a
DBusActivatable=trueapplication from the menu creates no scope, while regular launches keep getting theirs: