fix: migrate windows and layer surfaces on primary output hot-unplug#1024
Draft
deepin-wm wants to merge 1 commit into
Draft
fix: migrate windows and layer surfaces on primary output hot-unplug#1024deepin-wm wants to merge 1 commit into
deepin-wm wants to merge 1 commit into
Conversation
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Sorry @deepin-wm, you have reached your weekly rate limit of 500000 diff characters.
Please try again later or upgrade to continue using Sourcery
|
Skipping CI for Draft Pull Request. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: deepin-wm The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
deepin-wm
force-pushed
the
fix/primary-hotunplug-migration
branch
from
445c561 to
87a225b
Compare
1. Fix onScreenRemoved missing primary migration when removeOutput already switched primary output before onScreenRemoved is called 2. Extract migrateSurfacesToNewPrimary as a public method to eliminate duplicated migration logic in onScreenRemoved and onScreenDisabled 3. Add position correction for remaining output surfaces after output layout change, with normalGeometry sync for XdgToplevel 4. Migrate layer surfaces to remaining output instead of closing them when output is removed, and trigger arrangeLayerSurfaces for final layout Log: Fix windows and layer surfaces not displaying on remaining screen after primary output hot-unplug in extension mode Influence: 1. Test hot-unplug primary output in dual-screen extension mode 2. Verify windows on secondary screen move correctly to remaining screen 3. Verify layer surfaces (panel/dock) migrate correctly after unplug 4. Test maximize/restore window after output removal 5. Verify Copy mode is not affected by the changes fix: 主屏热插拔时正确迁移窗口和层表面 1. 修复 onScreenRemoved 缺失主屏迁移逻辑，当 removeOutput 在 onScreenRemoved 之前已切换主屏输出时 2. 提取 migrateSurfacesToNewPrimary 为公共方法，消除 onScreenRemoved 和 onScreenDisabled 中的重复迁移逻辑 3. 添加输出布局变化后剩余输出上表面位置校正，同步更新 XdgToplevel 的 normalGeometry 4. 输出移除时将层表面迁移到剩余输出而非关闭，并触发 arrangeLayerSurfaces 进行最终布局 Log: 修复扩展模式下拔掉主屏后窗口和面板不显示在剩余屏幕的问题 Influence: 1. 测试双屏扩展模式下拔掉主屏 2. 验证副屏上的窗口正确移动到剩余屏幕 3. 验证层表面（面板/任务栏）在拔屏后正确迁移 4. 测试拔屏后最大化/还原窗口功能 5. 验证复制模式不受此变更影响 Fixes: linuxdeepin#1
deepin-wm
force-pushed
the
fix/primary-hotunplug-migration
branch
from
87a225b to
9960e41
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix windows and layer surfaces not displaying on remaining screen after primary output hot-unplug in extension mode.
Changes
outputlifecyclemanager.cpp/.h: Fix
onScreenRemovedmissing primary migration whenremoveOutputalready switched primary output beforeonScreenRemovedis called. ExtractmigrateSurfacesToNewPrimaryas a public method to eliminate duplicated migration logic.rootsurfacecontainer.cpp: Add position correction for remaining output surfaces after output layout change, with
normalGeometrysync forXdgToplevelto ensure maximize/restore works correctly.layersurfacecontainer.cpp: Migrate layer surfaces to remaining output instead of closing them when output is removed, and trigger
arrangeLayerSurfacesfor final layout.Test Plan
Fixes: #1