fix: window corner radius setting not taking effect#1022
Draft
deepin-wm wants to merge 1 commit into
Draft
Conversation
1. Use -1 as sentinel value to distinguish "never set" from "explicitly set" for per-window cornerRadius in both SurfaceWrapper and PersonalizationWindowContextV1 2. Reset per-window m_radius override to -1 when DConfig windowRadius changes, so radius() falls back to the new global value 3. Fix Layer type windows returning -1.0 instead of 0 when no per-window override is set 4. Add resetCornerRadius() method with early-return guard Influence: 1. Test window corner radius change via control center 2. Verify existing windows update radius in real-time 3. Test Layer windows do not show rounded corners fix: 窗口圆角设置不生效 1. 使用 -1 作为哨兵值区分"从未设置"和"显式设置"逐窗口 圆角半径，适用于 SurfaceWrapper 和 PersonalizationWindowContextV1 2. 当 DConfig windowRadius 变更时，将逐窗口 m_radius 覆盖 值重置为 -1，使 radius() 回退到新的全局值 3. 修复 Layer 类型窗口在无逐窗口覆盖时返回 -1.0 而非 0 4. 添加 resetCornerRadius() 方法，包含提前返回守卫 Influence: 1. 测试通过控制中心修改窗口圆角 2. 验证已存在窗口实时更新圆角 3. 测试 Layer 窗口不显示圆角 PMS: BUG-2500U1-271537
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Sorry @deepin-wm, you have reached your weekly rate limit of 500000 diff characters.
Please try again later or upgrade to continue using Sourcery
|
Skipping CI for Draft Pull Request. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: deepin-wm The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use -1 as sentinel value to distinguish "never set" from "explicitly set" for per-window cornerRadius, and reset per-window overrides when DConfig windowRadius changes.
Changes
Testing
PMS: BUG-2500U1-271537