fix: empty wallpaper in multitaskview workspace#1018
Conversation
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Sorry @deepin-wm, you have reached your weekly rate limit of 500000 diff characters.
Please try again later or upgrade to continue using Sourcery
deepin-wm
force-pushed
the
fix/wm34-empty-wallpaper-multitaskview
branch
from
e2b80b5 to
5c9a59f
Compare
|
Skipping CI for Draft Pull Request. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: deepin-wm The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
1 similar comment
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: deepin-wm The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
deepin-wm
force-pushed
the
fix/wm34-empty-wallpaper-multitaskview
branch
2 times, most recently
from
863c1f6 to
97835a3
Compare
1. Fix workspaceId using index instead of actual workspace ID in WallpaperManager config 2. Fix MultitaskviewProxy.qml wallpaper binding to use delegate workspace model instead of current workspace 3. Update copyright year from 2024 to 2024-2026 in MultitaskviewProxy.qml (file modified in 2026) 4. Add retry mechanism for wallpaper Surface lookup failure with max 5 retries and exponential backoff 5. Add empty list guard in syncAddWorkspace to prevent workspaces[0] out-of-bounds access 6. Add containsWorkspace method to WallpaperOutputConfig for ID-based workspace existence check 7. Add syncRemoveWorkspace to clean up config on workspace removal, with Helper public wrapper for proper encapsulation Log: Fixed empty wallpaper when adding new workspace in multitaskview Influence: 1. Test adding new workspace in multitaskview and verify wallpaper displays correctly 2. Test removing workspace and verify wallpaper config is cleaned up 3. Test wallpaper Surface retry mechanism with slow-loading surfaces 4. Test workspace wallpaper switching between multiple workspaces fix: 多任务视图添加工作区壁纸为空 1. 修复 WallpaperManager 配置中 workspaceId 使用索引 而非实际工作区 ID 的问题 2. 修复 MultitaskviewProxy.qml 中壁纸绑定使用代理 工作区模型而非当前工作区的问题 3. 更新 MultitaskviewProxy.qml 版权年份从 2024 至 2024-2026（文件于 2026 年修改） 4. 添加壁纸 Surface 查找失败时的重试机制，最大 重试 5 次并使用指数退避 5. 在 syncAddWorkspace 中添加空列表保护，防止 workspaces[0] 越界访问 6. 添加 containsWorkspace 方法用于基于 ID 的工作区 存在性检查 7. 添加 syncRemoveWorkspace 方法在删除工作区时 清理配置，并通过 Helper 公共方法包装以保持 正确的封装性 Log: 修复多任务视图添加工作区时壁纸显示为空的问题 Influence: 1. 测试多任务视图中添加新工作区并验证壁纸正常显示 2. 测试删除工作区并验证壁纸配置被正确清理 3. 测试壁纸 Surface 重试机制在慢加载场景下的表现 4. 测试多个工作区之间切换壁纸的显示
deepin-wm
force-pushed
the
fix/wm34-empty-wallpaper-multitaskview
branch
from
97835a3 to
702f3e6
Compare
deepin-wm
changed the title
2 participants
Changes
Testing
变更内容
测试建议