fix: safe iteration with removeAt/erase across codebase

[deepin-wm]

Summary

Iterator/erase/remove safety fixes (P0+P1) to prevent use-after-destroy and iterator invalidation issues.

Changes

src/core/shellhandler.cpp — for+removeAt+break → indexOf+takeAt (8 places)

Replaced forward-iteration patterns that called removeAt(i) followed by break with a safer indexOf + takeAt approach. The original pattern was fragile: if the break were ever removed or the loop continued, the iterator would be invalidated.

waylib/src/server/kernel/wseat.cpp — removeAt(i--) → reverse iteration (2 places)

In doTouchNotifyCancel and doTouchFrame, replaced forward removeAt(i--) with reverse traversal (for (int i = size - 1; i >= 0; --i)). Reverse iteration is inherently safe with removeAt because removing an element only shifts indices below the current position.

waylib/src/server/kernel/wglobal.cpp — removeAt(i--)+--i → reverse iteration

In WWrapObject::safeDisconnect, replaced forward loop with removeAt(i) + manual --i reset with a clean reverse iteration loop. Same safety rationale as above.

waylib/src/server/qtquick/private/wbufferrenderer.cpp — add ordering constraint comment

Added a comment clarifying that destroySource(index) must be called before m_sourceList.removeAt(index) because destroySource accesses m_sourceList[index].

src/input/gestures.cpp — remove redundant deleteLater in destroyed callback (2 places)

Removed gesture->deleteLater() calls from unregisterSwipeGesture and unregisterHoldGesture. These callbacks are connected to QObject::destroyed, which fires during object destruction — calling deleteLater() on a being-destroyed object is redundant and potentially harmful.

Testing

• Touch input (multi-touch cancel and frame) for correctness after removing touch points
• Prelaunch splash creation, close, and timeout flows
• Xdg toplevel and xwayland surface creation with appId resolution
• Gesture unregister during active gesture recognition
• safeDisconnect with multiple connections to same receiver

[sourcery-ai]

Sorry @deepin-wm, you have reached your weekly rate limit of 500000 diff characters.

Please try again later or upgrade to continue using Sourcery

[wineee]

Code review

No issues found. Checked for bugs and CLAUDE.md compliance. The 5-file iterator/erase safety fix is well-reasoned:

• Reverse iteration in wseat.cpp and wglobal.cpp eliminates removeAt(i--) / removeAt(i)+--i patterns that risk skipping elements
• takeAt in shellhandler.cpp correctly preserves the removed value for destroyForSurface calls
• Removing deleteLater() in gestures.cpp is correct since destroyed callbacks fire during object destruction

🤖 Generated with Claude Code

[deepin-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: deepin-wm, wineee

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• debian/deepin/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment