Skip to content

chore(vintage): update UosAiAssistant icons#120

Open
F-windy wants to merge 1 commit into
masterfrom
update-vintage-uos-ai-assistant
Open

chore(vintage): update UosAiAssistant icons#120
F-windy wants to merge 1 commit into
masterfrom
update-vintage-uos-ai-assistant

Conversation

@F-windy

@F-windy F-windy commented Jul 6, 2026

Copy link
Copy Markdown

chore(vintage): update UosAiAssistant icons

  1. Replace UosAiAssistant.svg in the vintage theme across all 7 sizes (16/24/32/48/64/96/128)
  2. Refresh the icon artwork with the new design
  3. Keep file permissions at 644 and SVG viewBox matching each size

Log: Refresh the vintage UosAiAssistant icon set across all sizes

chore(vintage): 更新 UosAiAssistant 图标

  1. 替换 vintage 主题下 UosAiAssistant.svg 全部 7 个尺寸(16/24/32/48/64/96/128)
  2. 更新图标设计为新版样式
  3. 文件权限保持 644,各尺寸 SVG viewBox 与尺寸一致

Log: 更新 vintage 主题 UosAiAssistant 全套尺寸图标

@deepin-ci-robot

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: F-windy

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sourcery-ai

sourcery-ai Bot commented Jul 6, 2026

Copy link
Copy Markdown
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

This PR refreshes the UosAiAssistant icon artwork in the vintage theme by replacing the SVG assets for all available sizes while preserving sizing and file permissions.

File-Level Changes

Change Details Files
Update UosAiAssistant SVG icons across all vintage theme sizes to the new design while keeping sizing and permissions consistent.
  • Replace existing UosAiAssistant SVG artwork with the new design for each icon size (16, 24, 32, 48, 64, 96, 128).
  • Ensure each SVG’s viewBox matches its intended pixel size to avoid scaling or alignment issues.
  • Retain file permissions as 644 for all updated SVG assets.
vintage/apps/16/UosAiAssistant.svg
vintage/apps/24/UosAiAssistant.svg
vintage/apps/32/UosAiAssistant.svg
vintage/apps/48/UosAiAssistant.svg
vintage/apps/64/UosAiAssistant.svg
vintage/apps/96/UosAiAssistant.svg
vintage/apps/128/UosAiAssistant.svg

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@F-windy F-windy force-pushed the update-vintage-uos-ai-assistant branch from dfb3e17 to 18671fd Compare July 6, 2026 08:25
@F-windy F-windy closed this Jul 6, 2026
@F-windy F-windy reopened this Jul 6, 2026
Refresh UosAiAssistant.svg across all 7 sizes (16/24/32/48/64/96/128)
in the vintage theme.
@F-windy F-windy force-pushed the update-vintage-uos-ai-assistant branch from 18671fd to 0557703 Compare July 6, 2026 08:51
@deepin-ci-robot

Copy link
Copy Markdown

deepin pr auto review


★ 总体评分:100分

■ 【总体评价】

代码实现了AI助手应用图标的全面视觉重绘,从蓝色机器人形象变更为紫粉渐变六边形抽象标志,无任何逻辑或安全缺陷
评分理由:纯SVG资源文件变更,语法完全正确且无安全漏洞,符合满分标准

■ 【详细分析】

  • 1.语法逻辑(完全正确)✓
    本次变更涉及7个尺寸的SVG图标文件,所有修改均为合法的SVG/XML标签替换与属性更新。删除了旧的机器人路径与渐变定义,新增了六边形路径与紫粉渐变定义,XML闭合标签、命名空间引用及属性赋值均符合W3C SVG规范,无语法错误。
    建议:保持当前由设计工具导出的标准结构即可。
  • 2.代码质量(符合规范)✓
    图标资源由专业设计工具导出,内部ID命名(如linearGradient-2、path-10、filter-11)遵循了导出工具的默认自增规范,在单文件作用域内无冲突。图层结构清晰,通过<g>标签合理划分了背景矩形、内部六边形及阴影滤镜编组,符合UI图标资源的常规组织规范。
    建议:无需修改,当前质量满足图标主题库的集成要求。
  • 3.代码性能(无性能问题)✓
    新版图标采用了几何感更强的六边形路径替代原有的复杂贝塞尔曲线机器人身体,路径节点数量合理。使用的滤镜(如feGaussianBlur、feColorMatrix、feMerge)均为SVG标准原生滤镜,复杂度在系统图标渲染的可接受范围内,不会引起GPU过度绘制或卡顿。
    建议:无需优化。
  • 4.代码安全(存在0个安全漏洞)✓
    漏洞对比统计:新增漏洞 0 个,减少漏洞 0 个,持平 0 个
    本次变更为纯静态矢量图形资源替换,不包含任何可执行脚本(无<script>标签)、无外部资源引用(无<image>xlink:href指向外部URL)、无foreignObject嵌入HTML,彻底杜绝了XSS注入、外部资源劫持等SVG常见安全风险。
  • 建议:保持纯静态图形资源的提交规范,后续图标更新继续避免引入脚本或外部链接。

■ 【改进建议代码示例】

--- a/vintage/apps/128/UosAiAssistant.svg
+++ b/vintage/apps/128/UosAiAssistant.svg
@@ -1,5 +1,11 @@
+<?xml version="1.0" encoding="UTF-8"?>
 <svg width="128px" height="128px" viewBox="0 0 128 128" version="1.1" xmlns="http://www.w3.org/2000/svg" xmlns:xlink="http://www.w3.org/1999/xlink">
     <title>UosAiAssistant</title>
-    <!-- 此处严禁添加 <script> 或 <foreignObject> 标签以防范XSS -->
+    <!-- 安全规范:仅包含静态图形标签 <defs>, <g>, <path>, <linearGradient>, <filter> 等 -->
+    <!-- 安全规范:禁止使用 xlink:href 引用外部不受控的URL资源 -->
     <defs>
         <linearGradient x1="108.214078%" y1="39.0940622%" x2="50.7264237%" y2="22.8821794%" id="linearGradient-2">
             <stop stop-color="#6E5DCC" offset="0%"></stop>

@F-windy F-windy requested a review from xionglinlin July 6, 2026 09:16
@F-windy

F-windy commented Jul 6, 2026

Copy link
Copy Markdown
Author

两个失败 check 的诊断结论

这两个失败都是 deepin CI infra 问题,不是本 PR 代码的问题,不阻塞合并。

1. OBS: debian/x86_64 — OBS worker build root 损坏

公开构建日志(https://build.deepin.com/public/build/deepin:CI:linuxdeepin:deepin-icon-theme:PR-120/debian/x86_64/deepin-icon-theme/_log):

[7s] [1/148] installing binutils-common-2.46.50.20260617-1
[7s] chroot: failed to run command 'dpkg': No such file or directory
[7s] k3s-deepinci-amd3-ci-646897dbcb-ch9h7 failed "build ...deepin-icon-theme_2026.02.27+u001.dsc"
  • 失败 worker:k3s-deepinci-amd3-ci-646897dbcb-ch9h7,build root 里 dpkg 二进制缺失(前置还有 rm: cannot remove .../proc/...: Operation not permitted 权限错误)
  • 同源码 OBS: deepin_develop/x86_64 + aarch64 用的是另一个 worker,全部 ✅ pass
  • 3 次重试都 7 秒内快速失败,OBS scheduler 一直派给同一个坏 worker
  • 之前合并的 PR chore: delete deepin-license-activator #116chore: update changelog to 2026.02.27 #119根本没出现过 OBS: debian/x86_64 这个 check

修复建议(需 CI 团队):重启/隔离 worker k3s-deepinci-amd3-ci-646897dbcb-ch9h7,或重建其 build root。

2. sync-to-gitee — deepin CI K8s 集群级故障

  • 报告者:deepin-ci-robot(Prow bot),不在 GitHub Actions workflow 里
  • 错误:Pod scheduling timeout(K8s 5 分钟内调度不上 pod)
  • 全 deepin 仓普遍现象:deepin-icon-theme、deepin-ocr、deepin-terminal 最新 commit 全是同样 error
  • 最近合并的 PR chore: delete deepin-license-activator #116chore: update changelog to 2026.02.27 #119sync-to-gitee 全都是 error,照样合并
  • 注意:backup-to-gitee GitHub Actions workflow 是另一个东西(clone+push 到 gitee),已 ✅ pass——gitee 镜像同步其实已成功

修复建议(需 CI 团队):扩 K8s 集群容量或修 scheduler;sync-to-gitee 是冗余检查。


其他 check 状态

Check 状态
commitlint / CLA / license-check / Sourcery / deepin-pr-review ✅ pass(deepin-pr-review 100 分通过)
OBS: deepin_develop/x86_64 ✅ pass
OBS: deepin_develop/aarch64 ✅ pass
backup-to-gitee / sync-to-gitlab ✅ pass
OBS SCM/CI Workflow Integration ✅ pass
github-pr-review-ci ✅ pass

源码构建已全部通过。请 reviewer 放心 approve。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants