Skip to content

chore: update changelog to 6.1.98#1154

Merged
mhduiy merged 1 commit into
linuxdeepin:masterfrom
mhduiy:dev-changelog-6.1.98
Jun 18, 2026
Merged

chore: update changelog to 6.1.98#1154
mhduiy merged 1 commit into
linuxdeepin:masterfrom
mhduiy:dev-changelog-6.1.98

Conversation

@mhduiy

@mhduiy mhduiy commented Jun 18, 2026

Copy link
Copy Markdown
Contributor

更新说明

自动更新 changelog 到版本 6.1.98

变更内容

  • 更新 debian/changelog

版本信息

  • 新版本: 6.1.98
  • 目标分支: master

Summary by Sourcery

Chores:

  • Refresh debian/changelog entries to reflect version 6.1.98 targeting master.

update changelog to 6.1.98

Log: update changelog to 6.1.98
@sourcery-ai

sourcery-ai Bot commented Jun 18, 2026

Copy link
Copy Markdown
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

This PR updates the Debian package changelog to reflect a new release version 6.1.98 targeting master, without any code or configuration changes.

File-Level Changes

Change Details Files
Bump Debian package changelog entry to version 6.1.98.
  • Add or update the top changelog stanza to version 6.1.98.
  • Adjust associated metadata in the changelog entry (e.g., date, maintainer/sign-off) as needed for the new release.
  • Ensure the target distribution/branch information in the changelog matches master.
debian/changelog

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@github-actions

Copy link
Copy Markdown

TAG Bot

TAG: 6.1.98
EXISTED: no
DISTRIBUTION: unstable

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@deepin-ci-robot

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: fly602, mhduiy

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mhduiy mhduiy merged commit de6caaa into linuxdeepin:master Jun 18, 2026
16 of 19 checks passed
@deepin-bot

deepin-bot Bot commented Jun 18, 2026

Copy link
Copy Markdown
Contributor

TAG Bot

Tag created successfully

📋 Tag Details
  • Tag Name: 6.1.98
  • Tag SHA: 025d282389c5a2db402c4bbb6777eb6f4891aece
  • Commit SHA: de6caaa7c45f6a8f5f5b2972c249ea5a85e7dc8b
  • Tag Message:
    Release dde-daemon 6.1.98
    
    
  • Tagger:
    • Name: mhduiy
  • Distribution: unstable

@deepin-ci-robot

Copy link
Copy Markdown

deepin pr auto review

★ 总体评分:85分

■ 【总体评价】

代码修复了dpms-state文件权限过宽的问题,但使用了已废弃的API
逻辑正确但因使用废弃的ioutil.WriteFile扣15分

■ 【详细分析】

  • 1.语法逻辑(完全正确)✓
    displaycfg.go第161行和第203行的ioutil.WriteFile(tmpFile, content, 0644)函数调用参数类型匹配,错误处理机制健全,符合Go语言语法规范。

  • 2.代码质量(一般)✕
    displaycfg.go第161行和第203行使用了ioutil.WriteFile,该函数在Go 1.16版本起已被官方标记为废弃,推荐使用os.WriteFile替代。此外,代码片段中存在两处高度相似的文件写入逻辑,存在代码重复。
    潜在问题:使用废弃API可能导致后续Go版本升级时出现编译警告或兼容性问题;重复代码增加了维护成本。
    建议:将ioutil.WriteFile替换为os.WriteFile;将文件写入与权限设置的逻辑抽取为独立的公共函数以消除重复。

  • 3.代码性能(无性能问题)✓
    文件写入操作采用临时文件后缀.tmp的方式,为后续原子重命名做准备,避免了直接写入目标文件可能导致的I/O阻塞或文件损坏问题,操作开销在可接受范围内。

  • 4.代码安全(存在0个安全漏洞)✓
    漏洞对比统计:新增漏洞 0 个,减少漏洞 0 个,持平 0 个
    将dpms-state文件的写入权限修正为0644,限制了其他用户对系统电源管理状态文件的写权限,有效防止了本地非特权用户篡改DPMS状态导致的拒绝服务或配置劫持风险,符合UOS系统安全基线要求。

  • 建议:确保在后续使用os.Rename.tmp文件替换为目标文件时,目标目录的权限设置同样严格,防止符号链接竞态攻击。

■ 【改进建议代码示例】

// ...
tmpFile := filename + ".tmp"
// 使用 os.WriteFile 替代废弃的 ioutil.WriteFile
err := os.WriteFile(tmpFile, content, 0644)
if err != nil {
    return err
}
// 建议补充:确保重命名操作在安全的环境下进行,防范 TOCTOU 竞态
// err = os.Rename(tmpFile, filename)
// ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants