Skip to content

fix: Use verbosity level 3 for no_log#278

Merged
spetrosi merged 1 commit into
linux-system-roles:mainfrom
spetrosi:fix-verbosity-level
May 11, 2026
Merged

fix: Use verbosity level 3 for no_log#278
spetrosi merged 1 commit into
linux-system-roles:mainfrom
spetrosi:fix-verbosity-level

Conversation

@spetrosi

@spetrosi spetrosi commented May 11, 2026

Copy link
Copy Markdown
Contributor

Use ansible_verbosity < 3 instead of < 2 to show output with -vvv or higher.

Summary by Sourcery

Enhancements:

  • Relax the no_log verbosity threshold for the insights-packages package_facts task so its output is shown only when Ansible runs with verbosity 3 or above.

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
@spetrosi
spetrosi requested review from ptoscano and richm as code owners May 11, 2026 11:09
@sourcery-ai

sourcery-ai Bot commented May 11, 2026

Copy link
Copy Markdown
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Increase the verbosity threshold at which the Ansible package_facts task hides its output, so that logs are suppressed unless Ansible is run with -vvv or higher.

Sequence diagram for package_facts logging with updated verbosity threshold

sequenceDiagram
  actor Operator
  participant AnsibleEngine
  participant PackageFactsTask
  participant Logger

  Operator->>AnsibleEngine: run_playbook_with_verbosity_N
  AnsibleEngine->>PackageFactsTask: execute_with_no_log_ansible_verbosity_lt_3
  alt ansible_verbosity_lt_3
    PackageFactsTask-->>Logger: suppress_package_facts_output
  else ansible_verbosity_gte_3
    PackageFactsTask-->>Logger: send_package_facts_output
  end
Loading

Flow diagram for no_log behavior based on ansible_verbosity

flowchart TD
  Start[Run_ansible_playbook] --> SetVerbosity[Set_ansible_verbosity]
  SetVerbosity --> CheckVerbosity{ansible_verbosity < 3}
  CheckVerbosity -->|yes| NoLogTrue[Set_no_log_true_for_package_facts]
  CheckVerbosity -->|no| NoLogFalse[Set_no_log_false_for_package_facts]
  NoLogTrue --> OutputHidden[package_facts_output_hidden_in_logs]
  NoLogFalse --> OutputVisible[package_facts_output_visible_in_logs]
Loading

File-Level Changes

Change Details Files
Adjust Ansible logging suppression condition for the package_facts task to use verbosity level 3 instead of 2.
  • Update the no_log expression to ansible_verbosity < 3 so that task output is visible starting at -vvv verbosity.
  • Keep all task conditions and structure unchanged aside from the logging threshold tweak.
tasks/set_vars.yml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@spetrosi
spetrosi merged commit 0d7ad14 into linux-system-roles:main May 11, 2026
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant