docs: fix broken quoting in postfix_files defaults#239
Merged
richm merged 1 commit intoJun 9, 2026
Conversation
The comment added to `defaults/main.yml` for `postfix_files` in 73b7c72 (Added postfix_files feature as a simple means to add extra files/maps to the postfix config, 2024-06-09) included unneeded quotes. One of them was unclosed. Rather than add the closing quote, drop them to match the example provided in `README.md`. Adjust the address used in the content field of the `README.md` example to match what's used elsewhere in the examples. The commented variable in defaults and the README now contain the same data. Signed-off-by: Todd Zullinger <tmz@pobox.com>
📝 WalkthroughWalkthroughThis PR updates example configuration values and formatting in the Postfix Ansible role documentation. The ChangesDocumentation and example updates
🚥 Pre-merge checks | ✅ 4 | ❌ 2❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
richm
approved these changes
Jun 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The comment added to
defaults/main.ymlforpostfix_filesin 73b7c72 (Added postfix_files feature as a simple means to add extra files/maps to the postfix config, 2024-06-09) included unneeded quotes. One of them was unclosed. Rather than add the closing quote, drop them to match the example provided inREADME.md.Adjust the address used in the content field of the
README.mdexample to match what's used elsewhere in the examples. The commented variable in defaults and the README now contain the same data.Summary by CodeRabbit
postfix_filesand optional Postfix maps