Skip to content

fix: use hostonly_cmdline=yes on newer versions of OS#267

Merged
richm merged 1 commit into
linux-system-roles:mainfrom
richm:fix-use-hostonly-cmdline-where-supported
Jul 16, 2026
Merged

fix: use hostonly_cmdline=yes on newer versions of OS#267
richm merged 1 commit into
linux-system-roles:mainfrom
richm:fix-use-hostonly-cmdline-where-supported

Conversation

@richm

@richm richm commented Jul 13, 2026

Copy link
Copy Markdown
Contributor

Newer versions of the OS will configure dracut networking correctly with
the use of hostonly_cmdline=yes and this is what is recommended by
the NBDE documentation.

Signed-off-by: Rich Megginson rmeggins@redhat.com

Summary by CodeRabbit

  • Bug Fixes
    • Improved network boot configuration on Fedora and Red Hat 10 systems by using host-only kernel command-line settings.
    • Removed previous networking-specific boot options that could cause inconsistent initialization during startup.

Newer versions of the OS will configure dracut networking correctly with
the use of `hostonly_cmdline=yes` and this is what is recommended by
the NBDE documentation.

Signed-off-by: Rich Megginson <rmeggins@redhat.com>
@coderabbitai

coderabbitai Bot commented Jul 13, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 1b6bbaf3-23d7-48a6-8add-a360632ab115

📥 Commits

Reviewing files that changed from the base of the PR and between 9895559 and b03daa6.

📒 Files selected for processing (2)
  • vars/Fedora.yml
  • vars/RedHat_10.yml

📝 Walkthrough

Walkthrough

The Fedora and Red Hat 10 NBDE client dracut configurations now enable hostonly_cmdline=yes instead of appending rd.neednet=1 and omitting the ifcfg module.

Changes

Dracut host-only command line settings

Layer / File(s) Summary
Enable host-only dracut command line
vars/Fedora.yml, vars/RedHat_10.yml
__nbde_client_dracut_settings now uses hostonly_cmdline=yes and removes the previous networking-specific settings.
🚥 Pre-merge checks | ✅ 4 | ❌ 2

❌ Failed checks (2 warnings)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description is missing the required template sections for Enhancement, Reason, Result, and Issue Tracker Tickets. Rewrite the description using the repository template and fill in the missing sections, including issue tracker tickets if none are available.
Description Format ⚠️ Warning The PR description lacks required template sections; it only has narrative text and Signed-off-by, but no Enhancement/Reason/Result headings. Rewrite the PR description to include Enhancement, Reason, and Result sections, plus Signed-off-by; optionally add Issue Tracker Tickets and Assisted-by.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title follows Conventional Commits and clearly describes the change to use hostonly_cmdline=yes.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@richm

richm commented Jul 13, 2026

Copy link
Copy Markdown
Contributor Author

[citest]

@richm
richm requested a review from sergio-correia July 13, 2026 16:04
@richm

richm commented Jul 13, 2026

Copy link
Copy Markdown
Contributor Author

NOTE that there is some sort of issue with the Ansible url/uri module code on EL9 - using validate_certs=false is the workaround, even when using http - not sure what is the root cause.

@richm

richm commented Jul 13, 2026

Copy link
Copy Markdown
Contributor Author

note - el9 tests will fail until https://redhat.atlassian.net/browse/RHEL-191730 is built into a compose

@richm
richm merged commit f7a8153 into linux-system-roles:main Jul 16, 2026
43 of 45 checks passed
@richm
richm deleted the fix-use-hostonly-cmdline-where-supported branch July 16, 2026 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants