test: test for boolean values and null values are not allowed

[richm]

This is the test for #153

Signed-off-by: Rich Megginson rmeggins@redhat.com

Summary by Sourcery

Add tests to ensure boolean and null values are rejected in bootloader settings

Tests:

• Add a new playbook to test that passing true/on and false/off boolean values for bootloader settings triggers a failure
• Add tests to verify that passing null values for bootloader settings triggers a failure with the expected error message

[sourcery-ai]

Reviewer's Guide

Introduces a new Ansible test playbook that verifies the bootloader role rejects boolean and null values by triggering failures and asserting the correct error message.

File-Level Changes

Change	Details	Files
Add test playbook for boolean/null value validation	Create tests/tests_bool_null_not_allowed.yml with a new playbook Add block to test rejection of boolean true values Add block to test rejection of boolean false values Add block to test rejection of null values	tests/tests_bool_null_not_allowed.yml

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey @richm - I've reviewed your changes - here's some feedback:

• The three test blocks are nearly identical—consider parameterizing the value cases (true/false/null) in a loop to reduce duplication.
• In the “no boolean false values” block you still pass a quoted "true" for valid_value_1—swap it to "false" to match the test scenario.

Prompt for AI Agents

Please address the comments from this code review:
## Overall Comments
- The three test blocks are nearly identical—consider parameterizing the value cases (true/false/null) in a loop to reduce duplication.
- In the “no boolean false values” block you still pass a quoted "true" for valid_value_1—swap it to "false" to match the test scenario.

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.90%. Comparing base (63d7c0c) to head (6456de4).
⚠️ Report is 67 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #156      +/-   ##
==========================================
+ Coverage   78.43%   86.90%   +8.47%     
==========================================
  Files           2        2              
  Lines         255      275      +20     
==========================================
+ Hits          200      239      +39     
+ Misses         55       36      -19     

Flag	Coverage Δ
sanity	?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[richm]

[citest]