Skip to content

refactor: use ansible.posix 2.1.X for EL7 compatibility [citest_skip] - #85

Merged
richm merged 1 commit into
mainfrom
ansible-posix-2.1.0
May 20, 2026
Merged

refactor: use ansible.posix 2.1.X for EL7 compatibility [citest_skip]#85
richm merged 1 commit into
mainfrom
ansible-posix-2.1.0

Conversation

@richm

@richm richm commented May 18, 2026

Copy link
Copy Markdown
Contributor

The recently released ansible.posix 2.2.0 does not work on EL7.
Pin the version of ansible.posix to 2.1.X.

NOTE: Even though this role might not support EL7, this update
is applied to all system roles for consistency. Plus, when this
role is part of the system roles collection, all roles must use
the same version of ansible.posix - there is no way for a role
which is part of a collection to use a different version of a
dependency than the version used by the other roles.

Summary by CodeRabbit

  • Chores
    • Updated the ansible.posix collection dependency version constraint to >=2.1.0,<2.2.0.

Review Change Stack

@richm
richm requested a review from spetrosi as a code owner May 18, 2026 21:23
@richm richm self-assigned this May 18, 2026
@sourcery-ai

sourcery-ai Bot commented May 18, 2026

Copy link
Copy Markdown
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Pins the ansible.posix collection dependency to version 2.1.0 to maintain compatibility with EL7 by updating the collection requirements metadata.

File-Level Changes

Change Details Files
Pin the ansible.posix collection to a specific version compatible with EL7.
  • Update the collection requirements metadata to include a fixed ansible.posix version.
  • Ensure Ansible uses ansible.posix 2.1.0 instead of the latest incompatible release on EL7.
meta/collection-requirements.yml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've left some high level feedback:

  • Instead of pinning strictly to 2.1.0, consider using a version range constraint (e.g., >=2.1.0,<2.2.0) so that you can pick up future 2.1.x bugfixes while still avoiding 2.2.x on EL7.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- Instead of pinning strictly to `2.1.0`, consider using a version range constraint (e.g., `>=2.1.0,<2.2.0`) so that you can pick up future 2.1.x bugfixes while still avoiding 2.2.x on EL7.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@richm
richm force-pushed the ansible-posix-2.1.0 branch from 92163e2 to 00c7a53 Compare May 19, 2026 13:57
@richm richm changed the title refactor: use ansible.posix 2.1.0 for EL7 compatability refactor: use ansible.posix 2.1.X for EL7 compatibility May 19, 2026
@coderabbitai

coderabbitai Bot commented May 19, 2026

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 02567628-3fc1-419f-b4e0-e94709b4a2ed

📥 Commits

Reviewing files that changed from the base of the PR and between 798a66a and 3719969.

📒 Files selected for processing (1)
  • meta/collection-requirements.yml

📝 Walkthrough

Walkthrough

The PR adds an explicit version constraint for the ansible.posix collection in meta/collection-requirements.yml, setting it to >=2.1.0,<2.2.0 where previously no version was specified.

Changes

Collection Requirements Update

Layer / File(s) Summary
ansible.posix version constraint
meta/collection-requirements.yml
The ansible.posix collection dependency now includes version: ">=2.1.0,<2.2.0", adding an explicit version range where none existed before.
🚥 Pre-merge checks | ✅ 4 | ❌ 2

❌ Failed checks (2 warnings)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description is largely incomplete, missing required sections like 'Enhancement', 'Reason', and 'Result' that are specified in the repository's description template. Restructure the description to include the required template sections: Enhancement, Reason, Result, and Issue Tracker Tickets, organizing the existing content accordingly.
Description Format ⚠️ Warning PR description does not follow the required template format. Missing "Enhancement:" or "Feature:", "Reason:", and "Result:" labeled sections required by .github/pull_request_template.md. Reformat PR description to follow template: add Enhancement:/Feature: section, Reason: section, and Result: section with appropriate content.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title follows the Conventional Commits format with 'refactor' type and clearly describes the main change: pinning ansible.posix to version 2.1.X for EL7 compatibility.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@meta/collection-requirements.yml`:
- Line 5: The version constraint under the YAML key "version" currently uses
"<2.2.0" which allows versions below 2.1.X; update the "version" value to either
an exact EL7-compatible pin "2.1.0" or a bounded range ">=2.1.0,<2.2.0" to
enforce the intended 2.1.X requirement and ensure deterministic resolution.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: c483b8c9-dcb8-44fc-90a7-b6796896bde9

📥 Commits

Reviewing files that changed from the base of the PR and between 27aa75f and 00c7a53.

📒 Files selected for processing (1)
  • meta/collection-requirements.yml

Comment thread meta/collection-requirements.yml Outdated
@richm
richm force-pushed the ansible-posix-2.1.0 branch from 00c7a53 to 798a66a Compare May 19, 2026 15:37
@richm richm changed the title refactor: use ansible.posix 2.1.X for EL7 compatibility refactor: use ansible.posix 2.1.X for EL7 compatibility [citest_skip] May 20, 2026
The recently released ansible.posix 2.2.0 does not work on EL7.
Pin the version of ansible.posix to 2.1.X.

NOTE: Even though this role might not support EL7, this update
is applied to all system roles for consistency.  Plus, when this
role is part of the system roles collection, all roles must use
the same version of ansible.posix - there is no way for a role
which is part of a collection to use a different version of a
dependency than the version used by the other roles.

Signed-off-by: Rich Megginson <rmeggins@redhat.com>
@richm
richm force-pushed the ansible-posix-2.1.0 branch from 798a66a to 3719969 Compare May 20, 2026 13:41
@richm
richm merged commit f5a52fc into main May 20, 2026
12 checks passed
@richm
richm deleted the ansible-posix-2.1.0 branch May 20, 2026 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant