Skip to content

test: add role fingerprints to syslog - #82

Merged
richm merged 1 commit into
linux-system-roles:mainfrom
richm:fingerprint-2
Apr 22, 2026
Merged

test: add role fingerprints to syslog#82
richm merged 1 commit into
linux-system-roles:mainfrom
richm:fingerprint-2

Conversation

@richm

@richm richm commented Apr 22, 2026

Copy link
Copy Markdown
Contributor

Test updates based on testing with bootc and on other platforms.

Signed-off-by: Rich Megginson rmeggins@redhat.com

Summary by Sourcery

Tests:

  • Update default role test to skip journal-based fingerprint checks when /dev/log is absent and to use explicit Ansible module names.

Test updates based on testing with bootc and on other platforms.

Signed-off-by: Rich Megginson <rmeggins@redhat.com>
@richm
richm requested a review from spetrosi as a code owner April 22, 2026 20:45
@sourcery-ai

sourcery-ai Bot commented Apr 22, 2026

Copy link
Copy Markdown
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Adjusts the default test playbook to conditionally run syslog fingerprint checks only when /dev/log is present and modernizes Ansible module usage for the journal/shell step.

File-Level Changes

Change Details Files
Conditionally perform journalctl-based role fingerprint validation depending on the presence of /dev/log and update Ansible module invocations.
  • Add a stat task to detect the presence of /dev/log and register the result for later conditionals.
  • Guard the journal start-time fact and fingerprint verification shell task with a condition that /dev/log exists.
  • Replace bare set_fact with ansible.builtin.set_fact for clarity and consistency.
  • Convert the shell task to ansible.builtin.shell and explicitly set /bin/bash as the executable while preserving the journalctl/grep logic.
tests/tests_default.yml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@richm
richm merged commit 5a4a533 into linux-system-roles:main Apr 22, 2026
29 checks passed
@richm
richm deleted the fingerprint-2 branch April 22, 2026 20:45

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant