ci: tox-lsr 3.17.1 - previous update broke container tests, this fixes them [citest_skip]

[richm]

tox-lsr 3.17.1 has a fix for the broken container tests

There was one shell function for both setting up the callback plugins and the connection plugin.
When this function was skipped, the ANSIBLE_CONNECTION_PLUGINS environment variable was not
set, so all subsequent tests failed. The connection plugin must be present and the env. var.
must be set in order to run any container tests. The code was fixed to ensure that there is
always a connection plugin installed in the correct location and that ANSIBLE_CONNECTION_PLUGINS
is always set and contains this path.

Also, setting up the callback plugins and the connection plugin is already idempotent, so no
reason to skip them.

Signed-off-by: Rich Megginson rmeggins@redhat.com

Summary by Sourcery

Update CI workflows to use tox-lsr 3.17.1 and adjust test env configuration for container integration tests.

CI:

• Bump tox-lsr from 3.17.0 to 3.17.1 across GitHub Actions workflows.
• Ensure container integration tests always configure required Ansible plugins by no longer toggling the callback-related skip environment variable.
• Fix a minor indentation issue in the qemu-kvm integration tests workflow script.

[sourcery-ai]

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Updates GitHub Actions workflows to use tox-lsr 3.17.1 and ensures container tests always set up required Ansible connection plugins by no longer skipping callback/connection plugin setup between test runs.

Sequence diagram for container tests with mandatory plugin setup in tox-lsr 3.17.1

sequenceDiagram
  participant GitHubActionsRunner
  participant tox_lsr_3_17_1
  participant PluginSetup
  participant AnsibleContainerTests

  GitHubActionsRunner->>tox_lsr_3_17_1: pip install tox-lsr 3.17.1
  GitHubActionsRunner->>tox_lsr_3_17_1: invoke tox environment for container tests
  tox_lsr_3_17_1->>PluginSetup: run callback and connection plugin setup
  PluginSetup->>PluginSetup: ensure connection plugin installed
  PluginSetup->>PluginSetup: set ANSIBLE_CONNECTION_PLUGINS path
  PluginSetup-->>tox_lsr_3_17_1: plugin setup complete
  tox_lsr_3_17_1->>AnsibleContainerTests: run container tests with env ANSIBLE_CONNECTION_PLUGINS
  AnsibleContainerTests-->>GitHubActionsRunner: report test results

Loading

File-Level Changes

Change	Details	Files
Update all CI workflows to use tox-lsr 3.17.1 instead of 3.17.0.	Bump tox-lsr version in qemu-kvm integration workflow install step. Bump tox-lsr version in ansible-lint workflow install step. Bump tox-lsr version in ansible-managed-var-comment workflow install step. Bump tox-lsr version in ansible-test workflow install step.	.github/workflows/qemu-kvm-integration-tests.yml .github/workflows/ansible-lint.yml .github/workflows/ansible-managed-var-comment.yml .github/workflows/ansible-test.yml
Adjust qemu-kvm integration workflow test loop so callback/connection plugin setup is never skipped, and fix a small indentation issue in the container tag check.	Remove use of SKIP_CALLBACK_PLUGINS environment variable before and during the test loop so setup runs for every test. Fix indentation of the yq-based containerbuild tag check inside the image comparison conditional.	.github/workflows/qemu-kvm-integration-tests.yml

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey - I've reviewed your changes and they look great!

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}