ci: tox-lsr 3.17.0 - container test improvements, use ansible 2.20 for fedora 43 [citest_skip]

[richm]

tox-lsr 3.17.0 has some container test improvements - better output, faster runs

Use Ansible 2.20 for qemu/container tests on fedora 43

Signed-off-by: Rich Megginson rmeggins@redhat.com

Summary by Sourcery

Update CI workflows to use tox-lsr 3.17.0 and Ansible 2.20 for Fedora 43, improving container test behavior and performance.

CI:

• Bump tox-lsr version from 3.16.0 to 3.17.0 in GitHub Actions workflows for qemu tests, ansible-lint, ansible-managed-var-comment, and ansible-test.
• Switch Fedora 43 qemu and container test scenarios to use Ansible core 2.20.
• Adjust container test job environment variables to run full setup on the first test and skip requirements and callback plugins on subsequent runs for faster container testing.

[sourcery-ai]

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Updates CI workflows to use tox-lsr 3.17.0 and Ansible 2.20 for Fedora 43-based qemu/container tests, while optimizing container test runs through environment variable tweaks in the qemu-kvm integration workflow.

File-Level Changes

Change	Details	Files
Bump Ansible version for Fedora 43 qemu and container test matrices to 2.20.	Update qemu Fedora 43 matrix entry to use qemu-ansible-core-2-20 environment Update container Fedora 43 matrix entry to use container-ansible-core-2-20 environment Update container Fedora 43 bootc matrix entry to use container-ansible-core-2-20 environment	.github/workflows/qemu-kvm-integration-tests.yml
Upgrade tox-lsr used in CI workflows from 3.16.0 to 3.17.0.	Change tox-lsr version in qemu-kvm integration tests workflow install step Change tox-lsr version in ansible-lint workflow install step Change tox-lsr version in ansible-managed-var-comment workflow install step Change tox-lsr version in ansible-test workflow install step	.github/workflows/qemu-kvm-integration-tests.yml .github/workflows/ansible-lint.yml .github/workflows/ansible-managed-var-comment.yml .github/workflows/ansible-test.yml
Adjust container test execution loop to leverage tox-lsr’s new skipping capabilities for faster subsequent runs.	Remove LSR_CONTAINER_PROFILE and LSR_CONTAINER_PRETTY overrides that disabled profile/pretty output Initialize SKIP_REQUIREMENTS and SKIP_CALLBACK_PLUGINS to false before first test run Set SKIP_REQUIREMENTS and SKIP_CALLBACK_PLUGINS to true after each test iteration to speed up later runs	.github/workflows/qemu-kvm-integration-tests.yml

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey - I've left some high level feedback:

• The tox-lsr version is hard-coded in multiple workflows; consider introducing a single reusable workflow or a shared action/input to avoid having to update the version in several places on each bump.
• In the container test loop, you can simplify the SKIP_REQUIREMENTS/SKIP_CALLBACK_PLUGINS handling by setting them once before the loop and then only flipping them after the first iteration (e.g., with a simple flag) instead of exporting them on every pass.

Prompt for AI Agents

Please address the comments from this code review:

## Overall Comments
- The tox-lsr version is hard-coded in multiple workflows; consider introducing a single reusable workflow or a shared action/input to avoid having to update the version in several places on each bump.
- In the container test loop, you can simplify the SKIP_REQUIREMENTS/SKIP_CALLBACK_PLUGINS handling by setting them once before the loop and then only flipping them after the first iteration (e.g., with a simple flag) instead of exporting them on every pass.

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}