Skip to content

Add check for non-inclusive language - #10

Merged
richm merged 2 commits into
linux-system-roles:mainfrom
nhosoi:woke-action
Dec 21, 2022
Merged

Add check for non-inclusive language#10
richm merged 2 commits into
linux-system-roles:mainfrom
nhosoi:woke-action

Conversation

@nhosoi

@nhosoi nhosoi commented Dec 12, 2022

Copy link
Copy Markdown
Contributor

Add a check for usage of terms and language that is considered non-inclusive. We are using the woke tool for this with a wordlist that can be found at https://github.com/linux-system-roles/tox-lsr/blob/main/src/tox_lsr/config_files/woke.yml

@nhosoi nhosoi changed the title Add github action woke.yml (github.com/get-woke/woke-action) [WIP] Add github action woke.yml (github.com/get-woke/woke-action) Dec 12, 2022
@nhosoi

nhosoi commented Dec 12, 2022

Copy link
Copy Markdown
Contributor Author

Note: If d9924fa is acceptable, we can use the action woke-action with the released woke.

@nhosoi

nhosoi commented Dec 13, 2022

Copy link
Copy Markdown
Contributor Author

[citest]

Comment thread .github/workflows/woke.yml Outdated
runs-on: ubuntu-latest
steps:
- name: Checkout
uses: actions/checkout@v2

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
uses: actions/checkout@v2
uses: actions/checkout@v3

Warning: `dummy` may be insensitive, use `placeholder`, `sample` instead
Comment thread .github/workflows/woke.yml Outdated
@@ -0,0 +1,18 @@
# yamllint disable rule:line-length
# name: woke

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Without name, the status field is called .github/workflows/woke.yml / woke (pull_request)
Is there some reason you have # name: woke commented out?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, I don't think so... Anyway, I updated the top-level name as you suggested in linux-system-roles/crypto_policies#54 (comment), which is much better. Thanks!

Check for non-inclusive language / woke (pull_request)

Add a check for usage of terms and language that is considered
non-inclusive. We are using the woke tool for this with a wordlist
that can be found at
https://github.com/linux-system-roles/tox-lsr/blob/main/src/tox_lsr/config_files/woke.yml

Signed-off-by: Noriko Hosoi <nhosoi@redhat.com>
@nhosoi nhosoi changed the title [WIP] Add github action woke.yml (github.com/get-woke/woke-action) [WIP] Add check for non-inclusive language Dec 14, 2022
@nhosoi nhosoi changed the title [WIP] Add check for non-inclusive language Add check for non-inclusive language Dec 15, 2022
@nhosoi

nhosoi commented Dec 19, 2022

Copy link
Copy Markdown
Contributor Author

@richm, @spetrosi, @justin-stephenson, could you please review this pr one more time? Thanks in advance.

@richm
richm merged commit 1e874e5 into linux-system-roles:main Dec 21, 2022
richm added a commit to richm/linux-system-roles-ad_integration that referenced this pull request Jan 20, 2023
[1.0.1] - 2023-01-20
--------------------

### New Features

- none

### Bug Fixes

- ansible-lint 6.x fixes (linux-system-roles#11)

### Other Changes

- Add check for non-inclusive language (linux-system-roles#10)

Signed-off-by: Rich Megginson <rmeggins@redhat.com>
richm added a commit that referenced this pull request Jan 20, 2023
[1.0.1] - 2023-01-20
--------------------

### New Features

- none

### Bug Fixes

- ansible-lint 6.x fixes (#11)

### Other Changes

- Add check for non-inclusive language (#10)

Signed-off-by: Rich Megginson <rmeggins@redhat.com>

Signed-off-by: Rich Megginson <rmeggins@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants