coverage: run the daemons against a declared /etc/nvme - #518
Merged
martin-belanger merged 1 commit intoSep 2, 2026
Merged
Conversation
The coverage run read whatever the machine had. A stale exclusions.conf had been changing what it connected for an unknown number of runs, with nothing in the script saying so, and a runner with no /etc/nvme at all was a third answer again. The script now writes the host NQN, host ID and exclusion lists itself and bind-mounts that directory over /etc/nvme in the daemons' units, so libnvme's C code sees it too. A probe on a throw-away unit decides whether BindPaths= is usable; where it is not, the run falls back to the real directory and says so. Signed-off-by: Martin Belanger <martin.belanger@dell.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #518 +/- ##
=======================================
Coverage 71.32% 71.32%
=======================================
Files 16 16
Lines 2786 2786
=======================================
Hits 1987 1987
Misses 799 799 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The coverage run read whatever the machine had. A stale exclusions.conf had been changing what it connected for an unknown number of runs, with nothing in the script saying so, and a runner with no /etc/nvme at all was a third answer again.
The script now writes the host NQN, host ID and exclusion lists itself and bind-mounts that directory over /etc/nvme in the daemons' units, so libnvme's C code sees it too. A probe on a throw-away unit decides whether BindPaths= is usable; where it is not, the run falls back to the real directory and says so.