ci: lint staslib, which the linters never looked at - #509
Merged
Conversation
The Ruff steps name .build/stacctl, .build/stacd, .build/stafctl, .build/stafd and .build/staslib, but .build is the first line of .gitignore. Ruff honours it while traversing a directory, so .build/staslib expanded to nothing; the four scripts were checked only because an explicit file path bypasses the filter. Four files linted where there should have been twenty. --no-respect-gitignore is what test/meson.build already passes, which is why "meson test" has been catching things CI does not. The library is clean under both check and format, so this puts sixteen more files under the linters without changing any of them. Signed-off-by: Martin Belanger <martin.belanger@dell.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #509 +/- ##
=======================================
Coverage 67.68% 67.68%
=======================================
Files 16 16
Lines 2726 2726
=======================================
Hits 1845 1845
Misses 881 881 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Ruff steps name .build/stacctl, .build/stacd, .build/stafctl, .build/stafd and .build/staslib, but .build is the first line of .gitignore. Ruff honours it while traversing a directory, so .build/staslib expanded to nothing; the four scripts were checked only because an explicit file path bypasses the filter. Four files linted where there should have been twenty.
--no-respect-gitignore is what test/meson.build already passes, which is why "meson test" has been catching things CI does not. The library is clean under both check and format, so this puts sixteen more files under the linters without changing any of them.