fix(authnr-config): gate config subcommands on getInfo capabilities#291
Merged
Merged
Conversation
Each AuthenticatorConfig method now reads getInfo at entry and gates on capabilities before any UV round-trip, returning a clean platform error instead of relying on device rejection. toggle_always_uv is gated on the alwaysUv option only, not setMinPINLength. The two are independent subcommand options per CTAP 2.1 6.2.5 and the existing HID example treats them separately.
AlfioEmanueleFresta
force-pushed
the
fix/authenticator-config-gating
branch
from
35c995d to
5376aac
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Authenticator configuration subcommands were sent without first confirming the device advertises support, and the minimum PIN length RP list was sent without a bound. Each subcommand now checks the relevant getInfo capability before being sent, and the RP list is bounded to the device limit. This avoids predictable rejections and respects the authenticator declared limits.