Add flag to disable bucket webhook#389
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a runtime toggle to disable the Bucket validation admission webhook, primarily to support development environments where webhook infrastructure (e.g., cert provisioning) may not be present.
Changes:
- Introduces
--disable-bucket-validation-webhookCLI flag and gates Bucket webhook registration behind it. - Updates webhook documentation to mention the new flag.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| docs/WEBHOOKS.md | Documents the new flag for disabling the Bucket validation webhook. |
| cmd/provider/main.go | Adds the disable flag and conditionally skips Bucket webhook setup. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of your changes
Add flag
--disable-bucket-validation-webhookto globally disable the bucket validation webhook for all bucket MRs. This is required in order to run the provider without setting up the necessary webhook certs - this is useful for dev environments.Also updated webhooks doc
I have:
make ready-for-reviewto ensure this PR is ready for review.make ceph-chainsawto validate these changes against Ceph. This step is not always necessary. However, for changes related to S3 calls it is sensible to validate against an actual Ceph cluster. Localstack is used in our CI Chainsaw suite for convenience and there can be disparity in S3 behaviours between it and Ceph. Seedocs/TESTING.mdfor information on how to run tests against a Ceph cluster.backport release-x.ylabels to auto-backport this PR if necessary.How has this code been tested
Ran locally with flag set/unset. Also passes existing CI