Conversation
jsantell
force-pushed
the
use-local-server
branch
from
July 31, 2025 21:27
a4e924d to
d8b9d03
Compare
jsantell
force-pushed
the
use-local-server
branch
from
July 31, 2025 21:43
d8b9d03 to
6debf23
Compare
Author
|
Updated using github actions |
Author
|
Ah snapshot tests were working previously for me, fixing those up (it was deno fmt!) |
…ive 'example.com' page, reducing dependency on external services and intermittent failures.
jsantell
force-pushed
the
use-local-server
branch
from
July 31, 2025 22:40
6debf23 to
d4693a7
Compare
Author
Updated using the same HTML formatting as currently checked by the snapshot tests, looking good now |
Author
|
I'll look into the Windows failures, but no immediate ideas come to mind (and no local Window machines) |
Owner
|
Seems like potentially another snapshot issue? Strange for sure |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Optionally, and in CI, use a test static server instead of a live 'example.com' page, reducing dependency on external services and intermittent failures.
via #166 (comment):
Changes:
./tests/utils/helpers.tswithserverUrlandserverHostexports, using envTEST_SERVER_URLif defined, falling back tohttp://example.com./tests/utils/devserver.ts, which is a simple Deno static server serving identical content tohttp://example.comhttps://example.com-- doesdevserver.tsneed to support SSL?serverUrlLocally, tests now consistently pass for me (around 1s each), where previously they could hang, timing out after 60s