Fix CLI tests: remove deprecated mix_stderr parameter - #62
Conversation
The mix_stderr parameter was removed in click 8.0. Remove it from the CliRunner fixture to fix test failures. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
This PR updates the CLI test fixture to be compatible with Click 8.0+ by removing the deprecated mix_stderr parameter from the CliRunner initialization.
- Removes the
mix_stderr=Falseparameter which was deprecated in Click 8.0 - Updates the
cli_runnerfixture to use the default Click 8.0+ behavior
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| @pytest.fixture | ||
| def cli_runner(): | ||
| return CliRunner(mix_stderr=False) | ||
| return CliRunner() |
There was a problem hiding this comment.
Removing mix_stderr=False changes the default behavior to mix_stderr=True in Click 8.0+, which means result.stderr and result.stdout will no longer be separately available. This affects the debugging code at line 65-66 where result.stderr and result.stdout are accessed. Consider either: (1) passing mix_stderr=True explicitly to be clear about the behavior change, or (2) updating line 65-66 to only use result.output for debugging output.
| return CliRunner() | |
| return CliRunner(mix_stderr=False) |
Summary
mix_stderr=Falseparameter from CliRunner fixturemix_stderrparameter was removed in click 8.0Test plan
🤖 Generated with Claude Code