fix(js): allow clean consumer installs#49
Merged
Conversation
12 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
patch-packagelifecycle and patch payloadcommand-stream@^0.17.2, which contains the renderer fixes formerly carried by the patchReproduction
Installing
agent-commander@0.10.0as a dependency in a clean consumer project runs its publishedpostinstall. The lifecycle executes fromnode_modules/agent-commander, cannot find the hoistedcommand-streampackage there, and aborts the install with:This was reproduced by formal-ai Desktop Release run 30228722022 while consuming the package in link-assistant/formal-ai#851.
Verification
npm cinpm test— 240 passedbun test— 240 passeddeno test --allow-read --allow-run --allow-env --allow-net test/— 234 passed, 6 runtime-specific ignoresnpm run checkjs/and installed the tarball in an empty npm project; install succeeded withcommand-stream@0.17.2and no patch payloadCloses #48
Downstream: link-assistant/formal-ai#851