Skip to content

Update all - #1663

Merged
lingrino merged 1 commit into
mainfrom
renovate/all
Aug 24, 2026
Merged

Update all#1663
lingrino merged 1 commit into
mainfrom
renovate/all

Conversation

@renovate

@renovate renovate Bot commented Aug 24, 2026

Copy link
Copy Markdown
Contributor

This PR contains the following updates:

Package Type Update Change Age Confidence
docker/setup-buildx-action action minor v4.2.0v4.3.0 age confidence
github.com/stretchr/testify require patch v1.12.0v1.12.1 age confidence

Release Notes

docker/setup-buildx-action (docker/setup-buildx-action)

v4.3.0

Compare Source

Full Changelog: docker/setup-buildx-action@v4.2.0...v4.3.0

stretchr/testify (github.com/stretchr/testify)

v1.12.1

Compare Source

This is the first release which has the minimum dependencies practical in testify v1. The last remaining dependencies are github.com/stretchr/objx which itself has no dependencies, and go.yaml.in/yaml/v3. Removing objx would require v2, it cannot be vendored. Removing YAML would require vendoring the yaml library, which would do more harm than good. It's better to become aware of vulnerabilities in the official yaml package than to attempt to maintain our own.

What's Changed
New Contributors

Full Changelog: stretchr/testify@v1.12.0...v1.12.1

What's Changed
New Contributors

Full Changelog: stretchr/testify@v1.12.0...v1.12.1


Configuration

📅 Schedule: (in timezone America/Los_Angeles)

  • Branch creation
    • "before 8am on monday"
  • Automerge
    • At any time (no schedule defined)

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Aug 24, 2026

Copy link
Copy Markdown

Deploying vaku with  Cloudflare Pages  Cloudflare Pages

Latest commit: eccfb3c
Status: ✅  Deploy successful!
Preview URL: https://600915cb.vaku.pages.dev
Branch Preview URL: https://renovate-all.vaku.pages.dev

View logs

@renovate
renovate Bot requested a review from lingrino as a code owner August 24, 2026 07:01
@renovate
renovate Bot requested a review from lingrino August 24, 2026 07:01
@renovate

renovate Bot commented Aug 24, 2026

Copy link
Copy Markdown
Contributor Author

ℹ️ Artifact update notice

File name: go.mod

In order to perform the update(s) described in the table above, Renovate ran the go get command, which resulted in the following additional change(s):

  • 1 additional dependency was updated

Details:

Package Change
go.yaml.in/yaml/v3 v3.0.4 -> v3.0.5

@claude

claude Bot commented Aug 24, 2026

Copy link
Copy Markdown

Claude finished @renovate[bot]'s task in 1m 13s —— View job


Review

  • Gather context / read diff
  • Analyze dependency changes
  • Check go.mod / go.sum consistency
  • Post review

The two bumps themselves are safe. testify v1.12.1 is a yaml-library swap only (gopkg.in/yaml.v3go.yaml.in/yaml/v3), no assertion API surface change, and the repo only uses assert/require. docker/setup-buildx-action@v4.3.0 is transitive-dependency bumps. Nothing to change in this PR.

Two pre-existing issues this PR makes visible:

1. go.sum is accumulating stale entries — the tidy check in CI is a no-op

.github/workflows/validate.yml:48:

run: test -z $(go mod tidy)

go mod tidy writes nothing to stdout (diagnostics go to stderr), so $(go mod tidy) is always empty and test -z "" always succeeds. The step rewrites go.mod/go.sum in the CI checkout and then throws the result away — it has never actually validated anything.

Consequence is visible in this diff and across the file: superseded versions keep their full h1: module-zip lines instead of being pruned.

github.com/stretchr/testify v1.11.1 h1:...   # stale
github.com/stretchr/testify v1.12.0 h1:...   # stale after this PR
github.com/stretchr/testify v1.12.1 h1:...
go.yaml.in/yaml/v3 v3.0.4 h1:...             # stale after this PR
golang.org/x/sync v0.20.0 h1:...             # stale
golang.org/x/sync v0.21.0 h1:...             # stale

Renovate appends without tidying, and nothing catches it, so go.sum grows monotonically with every dependency PR. Suggested fix:

- name: go mod tidy
  run: |
    go mod tidy
    git diff --exit-code go.mod go.sum

Fix this →

2. Two yaml v3 implementations in the module graph

go.mod:73 now has go.yaml.in/yaml/v3 v3.0.5 (via testify) while go.mod:78 still has gopkg.in/yaml.v3 v3.0.1 (via the Vault deps). Both are indirect, both are the same library under different import paths. Harmless at build time, just worth knowing that govulncheck/dependency-scanning results need to be read against both paths until the Vault side migrates.

Not verified: I couldn't run go build, go test, or go mod tidy locally — those commands were blocked by the sandbox in this run, so the tidy claim above is based on reading go.sum directly, not on executing tidy. Repo CI is the authority on build/test.
· renovate/all

@lingrino
lingrino merged commit b9a0f1f into main Aug 24, 2026
7 of 8 checks passed
@lingrino
lingrino deleted the renovate/all branch August 24, 2026 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant