Repository navigation
swiftui: write image records per docs/image-metadata.md and show them in the preview - #132
Merged
Merged
Conversation
…in the preview The macOS app writes each picture's JSON record as docs/image-metadata.md lays it out (environment / request / result), reads both it and the old Record back, and shows it in a column of the preview window. libwaifu gains waifu_version_json and waifu_engine_device, and the model manager's catalog a versioned_name, for the fields only they know. Also: the big picture dims and shows an expand sign under the mouse; "Reuse these settings" restores the device; the preview opens at 1000x700 and resizes freely, and FitWindow is gone. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The macOS app now writes each picture's JSON record in the
docs/image-metadata.mdformat (environment/request/result, newImageRecord), reads it and the oldRecordback, and shows it in a column of the preview window. libwaifu gainswaifu_version_jsonandwaifu_engine_device, and the model manager's catalog JSON aversioned_name, for the fields only the libraries know. The preview'sFitWindowis removed: the window opens at 1000×700 and resizes freely.Also in the app
Session.devices, used byDeviceCardtoo).Record; the format only covers pictures.Notes
deviceis spelled as the doc spells it (cuda-cpu-offload, sometal-disk-offload), and is the device the engine resolved:autois never written.inputs.start_fromas the file it was read from; a pasted picture is copied tooutput/inputs/first so there is a path to name.tEXtchunks, the library writing the record itself, CLI / webui / WPF.Tests
./build/unittest,cargo test(waifu, waifu-modelmanager, waifu-cli),cargo build -p waifu-toolsandswift testpass;cargo fmt --allis clean. New:ImageRecordTests(layout, null revision, read back) and WaifuKit tests for the version, the resolved device andversionedName. No model test suite covers the files touched.🤖 Generated with Claude Code