Skip to content

cli: leave unfetched non-SDXL models out of img2img; fix Windows config test and waifu-tools build - #130

Merged
ling0322 merged 1 commit into
mainfrom
fix-ci-img2img-filter
Oct 15, 2026
Merged

ling0322 merged 1 commit into
mainfrom
fix-ci-img2img-filter

Conversation

@ling0322

Copy link
Copy Markdown
Owner

draws_from_a_picture in waifu-cli now judges a published model whose manifest is not on the disk by its family — only sdxl can start from a picture — instead of saying yes. Also fixes config::tests::what_is_written_is_read_back_and_the_rest_is_kept on Windows and the waifu-tools build broken by #127.

Why

CI on main has been red since #124:

Tests

  • New draw::tests::a_model_not_yet_fetched_is_judged_by_its_family.
  • ./build/unittest, cargo test for waifu, waifu-modelmanager and waifu-cli, and cargo build -p waifu-tools pass on macOS. waifu-cli also passes with XDG_CACHE_HOME/XDG_CONFIG_HOME pointed at an empty directory, as on CI.
  • The Windows fix is verified only by this PR's CI.
  • Model tests were skipped; no inference code changed.

🤖 Generated with Claude Code

…uild

- waifu-cli: draws_from_a_picture judges a published model with no manifest on
  the disk by its family (only sdxl can start from a picture), so Anima, Krea 2
  and Qwen-Image are left out of the img2img list before they are fetched.
- waifu-modelmanager: the config round-trip test uses a path that is absolute
  on Windows too.
- waifu-tools: parameters calls w2v_bert::graph with its signature since #127.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

@ling0322 ling0322 left a comment

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed c0a59b3. No actionable correctness findings. Checked the unfetched-model fallback against the catalog names consumed by the TUI, the existing manifest-first capability check, the config test's absolute path, and the updated w2v_bert::graph call.

Local validation on macOS with XDG_CACHE_HOME and XDG_CONFIG_HOME pointed to a fresh empty directory: waifu-cli tests 175 passed; waifu-modelmanager tests 61 passed and 1 ignored. cargo check -p waifu-tools --bin parameters and git diff --check also passed. Windows behavior was inspected but not executed locally; the PR's Windows CI was still in progress when checked. Model tests were not run.

@ling0322
ling0322 merged commit a59e0a8 into main Oct 15, 2026
2 of 3 checks passed
@ling0322
ling0322 deleted the fix-ci-img2img-filter branch October 24, 2026 06:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant