Repository navigation
cli: leave unfetched non-SDXL models out of img2img; fix Windows config test and waifu-tools build - #130
Merged
Conversation
…uild - waifu-cli: draws_from_a_picture judges a published model with no manifest on the disk by its family (only sdxl can start from a picture), so Anima, Krea 2 and Qwen-Image are left out of the img2img list before they are fetched. - waifu-modelmanager: the config round-trip test uses a path that is absolute on Windows too. - waifu-tools: parameters calls w2v_bert::graph with its signature since #127. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
ling0322
commented
Oct 15, 2026
ling0322
left a comment
Owner
Author
There was a problem hiding this comment.
Reviewed c0a59b3. No actionable correctness findings. Checked the unfetched-model fallback against the catalog names consumed by the TUI, the existing manifest-first capability check, the config test's absolute path, and the updated w2v_bert::graph call.
Local validation on macOS with XDG_CACHE_HOME and XDG_CONFIG_HOME pointed to a fresh empty directory: waifu-cli tests 175 passed; waifu-modelmanager tests 61 passed and 1 ignored. cargo check -p waifu-tools --bin parameters and git diff --check also passed. Windows behavior was inspected but not executed locally; the PR's Windows CI was still in progress when checked. Model tests were not run.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
draws_from_a_picturein waifu-cli now judges a published model whose manifest is not on the disk by its family — onlysdxlcan start from a picture — instead of saying yes. Also fixesconfig::tests::what_is_written_is_read_back_and_the_rest_is_kepton Windows and thewaifu-toolsbuild broken by #127.Why
CI on
mainhas been red since #124:tui::models::tests::the_list_is_the_tasks_own. waifu: split into libwaifu and libwaifu_modelmanager; CLI on their C APIs #124 changeddraws_from_a_pictureto ask the engine about a manifest on the disk and to returntruewhen there was none. CI has no models downloaded, soanima:turboandanima:miaomiaowere offered for img2img. It passed locally only where Anima had been fetched./data/modelshas no drive letter, so joining it onto the settings file's directory givesC:/data/models. The test now uses an absolute temp path; the code is unchanged.waifu-tools. flint: add conv_transpose1d, snake, pad1d, clamp, stft and istft operators; remove waifu::audio's compositions #127 droppeddtype/deviceand theResultfromw2v_bert::graph;bin/parameters.rsstill passed them.Tests
draw::tests::a_model_not_yet_fetched_is_judged_by_its_family../build/unittest,cargo testfor waifu, waifu-modelmanager and waifu-cli, andcargo build -p waifu-toolspass on macOS. waifu-cli also passes withXDG_CACHE_HOME/XDG_CONFIG_HOMEpointed at an empty directory, as on CI.🤖 Generated with Claude Code