Repository navigation
rust: run cargo fmt --all over the workspace; require it before commits - #126
Merged
Merged
Conversation
Format every crate in the workspace (waifu, waifu-cli, waifu-modelmanager, waifu-tools) with the default rustfmt style, and add a Formatting section to CLAUDE.md asking for `cargo fmt --all` before committing any Rust change. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
ling0322
added a commit
that referenced
this pull request
Oct 15, 2026
Brings in #125 (anima: adapter.rs and dit.rs from diffusers) and #126 (cargo fmt --all over the workspace). The four conflicts -- waifu/src/flint/{functional,mod}.rs and waifu/tests/audio{,_cuda}.rs -- were formatting only on main's side: each is the merge base run through rustfmt. They take this branch's content, and the workspace is then run through cargo fmt --all as CLAUDE.md now asks. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01WkfaWVmr9m5uxoJ4grPuLm
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Formats every crate in the workspace (
waifu,waifu-cli,waifu-modelmanager,waifu-tools) withcargo fmt --allin the default rustfmt style, and adds a Formatting section to CLAUDE.md requiringcargo fmt --allbefore any Rust commit. No behaviour changes: 73 Rust files are reformatted, plus CLAUDE.md.Why
Nothing ran rustfmt — not CI, not a hook, not CLAUDE.md — so formatting had drifted across most of the tree. Landing this as a format-only PR keeps the churn out of feature diffs.
Tests
./build/unittest: 9594 assertions passedcargo test --manifest-path waifu/Cargo.toml: 392 passed, 111 ignoredcargo test -p waifu-modelmanager: 61 passed, 1 ignoredcargo build -p waifu-tools: buildscargo test -p waifu-cli: 173 passed, 1 failed —tui::models::tests::the_list_is_the_tasks_own(anima:miaomiaoappears in the Img2Img list). It fails the same way on unformattedmainatfec7836, so it is pre-existing and not touched here.Not included
CI does not check formatting yet; a
cargo fmt --all --checkstep inci.ymlwould keep the tree from drifting again.🤖 Generated with Claude Code