Skip to content

v0.2.2 ci: skip unaffected checks and speed up daemon tests - #647

Merged
tianxiaochannel-oss88 merged 7 commits into
mainfrom
codex/daemon-test-performance
Nov 3, 2026
Merged

tianxiaochannel-oss88 merged 7 commits into
mainfrom
codex/daemon-test-performance

Conversation

@tianxiaochannel-oss88

@tianxiaochannel-oss88 tianxiaochannel-oss88 commented Nov 2, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

CI selects affected packages and consumers, omits empty jobs and reduces Daemon fixture and worker overhead. Unknown inputs, shared infrastructure, daily/manual runs and full-ci retain full regression. The aggregate rejects missing, skipped, cancelled or unsuccessful selected jobs.

  • Source changes propagate to consumers; test changes select owners and known fixture importers. Manifest narrowing requires verified identity, unchanged scripts and the union of old/current dependency graphs.
  • Core and Daemon share a longest-first worker queue with exclusive-file scheduling. Empty SQLite templates remain process-local and cold migration/recovery coverage is retained.
  • TypeScript tests are discovered and typechecked. Installer, model-cache, provider and translation workflows retain explicit input boundaries and the validated Node baseline.
  • Login deadline coverage retains real HTTP/native I/O, the 1199/1200ms boundary and cleanup assertions. No production timeout, retry policy, assertion, skip or watchdog was relaxed.

Latest Main Synchronization

Candidate: 68dfe4a18fb910fe8e9d5d2ecbb91b813e7dcd21, tree d8028bfd1694463709f227c1213db254ac4d78f3. Ordinary merge parents: prior PR head 04f09b2a12df907816c9c3a75b53cd570911c022 and main@ccbfd89fca621e848ae536ed09cfd4f2dacbdbaa (#645).

  • Reconciled all five conflicts without rebase or force push.
  • Preserved main's four Channel suites and shared helper. AST checks conserve all 216 optimized fixture calls and 225 static test definitions, corresponding to 226 runtime cases; cold/custom directories remain unchanged.
  • Preserved main's shared Thread/Turn recovery topology, real source writes and finally metadata flush. The typed regression retains 500 blockers and verifies paging, ownership, frozen inputs and reopen behavior, with one production-capped 200-row metadata read.
  • Preserved main's dependency overrides, frozen lockfile, security patches and new regression tests. The original assertion bodies were not weakened.
  • Split Channel files use ordinary workers and the default watchdog. The existing fair-scan exception and required native coverage remain intact.
  • Updated CI maintenance guidance for the combined implementation. The earlier Channel timing comparison is explicitly historical, predating v0.2.1 fix: stabilize full CI and dependency security checks #645's file split.

Local Verification

Commands used Node 22.22.1. Counts below are independently observed TAP/tool summaries, not unique whole-repository totals or evidence-ledger counters.

Check Observed result
Frozen dependency install; selected Daemon dependency-graph build:ci Successful; lockfile unchanged
Complete common-fast command, including CI .mjs/.ts and native contracts 343 cases: 342 passed, 1 platform skip, no failures
Daemon production/test typecheck and CI test typecheck Successful
SQLite and recovery fixture regressions 7 cases passed
14-file integration lane 451 cases: 450 passed, 1 media waiting timeout, no skips; initial lane remains failed
Complete approval-policy file diagnostic rerun 103 cases passed, no skips; no source or timeout changes
Dependency security command: mobile, Daemon and root regressions 23 + 2 + 148 cases passed, no skips
Markdown links / public safety / license policy 543 documents / 6640 files / 1284 versions across 23 license families
Conflict markers, Channel conservation and whitespace Successful

The integration lane's only failure was media production project run validates every legacy target before creating any scene run: its unchanged 5000ms wait expired with the media job still running and no error. In-memory source comparison proved the approval test equals main after normalizing only fixture imports/calls. Three alternating trials each of main and this candidate passed that case, followed by a successful complete-file diagnostic rerun. This is not a demonstrated flake fix or proof of stability; the initial failure remains disclosed. All four Channel files, four recovery consumers, MCP transport, runner acceptance, host write bundle and login routes passed their first integrated run.

The first security run found four minimatch9 behavior failures. Investigation reproduced pnpm 10.0.0's incremental import omitting the patch despite a correct hash-bearing directory. An independent clean installation passed both versions/formats. Applying the existing frozen repository patch to this local installation restored CJS/ESM files byte-for-byte to that clean installation, after which the original complete security command passed. No manifest, lockfile, patch or security assertion was changed to obtain that result. The current-head hosted dependency-security lane also passed on its runner.

Hosted CI And Landing

Hosted verification passed for exact head 68dfe4a18fb910fe8e9d5d2ecbb91b813e7dcd21. The single watcher completed successfully, the exact-head all-check gate returned VERDICT PASS, and an independent readback lists 22 successful check entries. Main CI run 41567989154 completed successfully; CodeQL and both Windows contract workflows also passed.

The immutable hosted plan matches current source discovery exactly. All eight complete shard reports pass coverage validation: 261 Linux Core files and 594 macOS Daemon files, each assigned and reported once. These are file counts, not test-case counts. All four Channel suites, both typed regressions and login routes passed. The hosted approval-policy file passed 103/103 cases with no skips, including the initially timing-sensitive media case at approximately 4.28 seconds; this does not erase its initial local failure or prove the absence of future flakes.

Daemon shard job wall times were 13m46s, 18m55s, 18m37s and 18m29s. Their test steps took 11m48s, 16m43s, 16m16s and 16m17s respectively. These single-run measurements exclude pre-start runner queuing and are not a controlled before/after speedup. The full CI run spanned 50m36s from creation to final update, including queuing; end-to-end latency is not solved by the shorter individual job times.

Latest authoritative readback remains OPEN / MERGEABLE / BLOCKED, with live main still at ccbfd89fca621e848ae536ed09cfd4f2dacbdbaa, no queue entry and no merge SHA. The existing SQUASH auto-merge request remains enabled and was not replayed, cancelled or replaced. Synchronization and verification are complete, but only authoritative MERGED state with a merge commit confirms landing.

The previous full review, documentation audit and shipping receipt predate this reconciliation. Receipt carry refused because the conflict-resolved product diff changed; they have not been rebound or presented as fresh. This update records scoped integration checks, not a third formal review/audit or a fresh whole-tree shipping receipt.

  • Synchronize main and resolve conflicts on the existing PR branch.
  • Run scoped local verification and disclose the initial timing-sensitive failure.
  • Verify hosted checks for the exact new head.
  • Confirm authoritative merge completion.

Remaining Scope

Root package.json, lockfile, shared CI infrastructure and VERSION changes still force full regression; automatic version bumps can therefore defeat narrowing. Full Daemon regression remains slow. Daily success-evidence deduplication, weekly-only macOS scheduling and platform test splitting are not implemented. No protection rules, global tools, unrelated worktrees, deployment or release publication were changed.

tianxiaochannel-oss88 and others added 2 commits November 3, 2026 02:52
Select checks from the complete PR dependency graph and fail closed on missing selected jobs. Preserve full and native coverage while sharing isolated SQLite setup and balancing file workers. Document the selection rules and protect the runner contracts.
Co-Authored-By: OpenAI Codex <noreply@openai.com>
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 2, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ⚠️ Failed 2026-11-03T02:49:55.056782Z
We couldn’t complete this review. Comment @codex review to try again.
68dfe4a New commits
🔒 Security Review ✅ Completed 2026-11-03T02:58:00.711012Z 68dfe4a New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@tianxiaochannel-oss88
tianxiaochannel-oss88 enabled auto-merge (squash) November 3, 2026 00:07
@tianxiaochannel-oss88
tianxiaochannel-oss88 merged commit b5713e5 into main Nov 3, 2026
22 checks passed
@tianxiaochannel-oss88
tianxiaochannel-oss88 deleted the codex/daemon-test-performance branch November 3, 2026 06:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant