Repository navigation
ci: add isolated non-blocking timing telemetry - #631
Open
tianxiaochannel-oss88 wants to merge 5 commits into
Open
tianxiaochannel-oss88 wants to merge 5 commits into
tianxiaochannel-oss88 wants to merge 5 commits into
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ci-telemetryartifact and GitHub Step Summary.Validation
git diff --checkpass.actionlintis not installed locally; hosted Actions validation remains necessary.41343476793, attempt 1, on headdfc6a458ed02d93c42e18ea4544f504f1a525e21failed. The PR is not ready to merge; see the investigation below.Hosted CI Investigation (Merge Blocked)
Daemon tests (shard 0), job124958879262. The required aggregate quality gate also failed. Other daemon shards, package/core lanes, builds, typechecks, platform smoke checks, and CodeQL passed on this head.packages/daemon/test/channel-node-invocation-binding.test.mjs:113expected the first real ESM command to returnsucceeded, but it returnedtimed_outwith the existingtimeoutMs: 4000request. The subtest took 4896.695 ms; that file reported four passing tests and one failure, then exited normally. This is not a reproduced HTTP-server leak or a file-runner deadline failure.dfc6a458, the workflow diff only appended the telemetry job. The failing test, product sources, dependencies/lockfile, and shard/process runner inputs were unchanged from basec472c62fe80ea52a579593c289e6bca42c450205. Telemetry depends on the aggregate quality job and started after it ended, so telemetry execution did not overlap this failure. The later diagnostic-only test changes are described separately below.acp-approval-journal.test.mjsalongside the victim. The original four-second command limit was unchanged. Package sources and runner inputs were identical; the baseline reused the head's built package outputs and dependencies via symlinks, so these are not independently built revisions or hosted-runner reproductions.c472c62fdfc6a458a7594c74aab4(1581.069 ms),7e752ce119b1(2679.953 ms),63bc33230b44(2309.817 ms), and PR v0.2.0 perf: speed up CI with bounded test shards and cleanup #630 headdd1212c2bb21(1656.897 ms). The first failing head in this limited sample isdfc6a458; that observation does not establish a causal commit. Historical logs do not contain individual command startup/exit timing.Diagnostic Follow-Up (Not A Flake Fix)
node_goal_command_diagnostic_v1records command sequence, the unchanged 4000 ms limit, runtime version/platform, lifecycle timings, status, duration, exit code/signal, process cleanup observation and stdout/stderr byte counts. Commands, paths, environment values, output bodies, artifact payloads and error messages are excluded. Listeners and the diagnostic subscription are detached on returned and thrown paths.status=timed_out,stopReason=timeout, andsettledBy=close. The file remainsfailed, exit 1, and its diagnostic is retained in the normal per-file report log. These are diagnostic validation probes, not reproductions or explanations of the hosted fault.Observation Limits