Repository navigation
test(ci): stabilize workspace handoff ordering and full-ci dispatch - #623
Merged
Merged
Conversation
tianxiaochannel-oss88
marked this pull request as ready for review
October 30, 2026 02:43
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The workspace handoff regression assumes that an HTTP request has entered the server mutation queue after a 50 ms sleep. Under CI load, the later reply can overtake the request and fail the final binding assertions. This failed in the performance candidate run and again in the post-merge scheduled run 40855279750.
Wait for the server to finish reading the handoff request body and cross the handler's microtask boundary before submitting the later reply. Keep every binding and factory-call assertion, and bound the test with the existing 10-second async timeout. No product code changes.
The
full-cilabel helper also fails withfatal: not a git repositorybecause it intentionally has no checkout. Pass the repository explicitly togh workflow run, retaining the fork guard, permissions and checkout-free execution.Validation
channel-workspace.test.mjs: 226 passed, 0 failures.git diff --checkpasses.Full target-runner CI 40918754725 passed on commit
18c425855793119719f93afb33cbe8df5d470e20: all four real macOS daemon shards, unit/Web tests, type checks, dependency/security checks, Linux contracts, native helper smoke and the final quality gate succeeded. The handoff regression passed in shard 0.Daemon test steps took 17m44s, 14m24s, 12m33s and 11m10s for shards 0 through 3. The complete run took 23m57s, including setup and scheduling. These are observed durations, not a controlled comparison of total CI speed.
Follow-up to the merged performance change #618. The branch includes current main
7c7861020fc3eacddd284459c4d6005c74a554f6. The final head4c22eff501e890c084fa0a2dca7cc7358a7bc7adretains the same three-file change. Local CI contract checks again passed (221 passed, one environment skip).Final pull-request CI 40994387706 passed on that exact head, together with CodeQL: all 15 checks succeeded. The full CI run took 24m29s; daemon test steps for shards 0 through 3 took 13m46s, 10m04s, 8m12s and 9m33s, and unit tests took 18m13s. The handoff regression passed in shard 0. These are observed durations, not a controlled speed comparison.
The label helper runs from the base branch, so its changed workflow itself cannot execute on a label event until integrated; the exact explicit-repository dispatch command was successfully exercised from a directory without a Git repository. No product behavior or deployment changes are included.