Repository navigation
feat(engines): discover installed engines and managed install (lifecycle P0+P1) - #604
Conversation
…cle P0+P1) Scan PATH and well-known locations for existing Codex/Claude/Kimi/OpenClaw installations and surface them in engine settings with a one-click adopt action. Add managed installs for Codex and Claude Code: download the pinned platform package from npm, verify the registry integrity digest, extract atomically under ~/.ling-stack/engines/<engine>/<version>/, and probe the installed binary before offering it as a profile. Kimi and OpenClaw keep manual guidance until their distribution channels are verified. Web and desktop share the new /execution-engines/discovery and /execution-engines/<id>/install routes through the api-client and the desktop IPC bridge. Evidence: real-daemon e2e with screenshot.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
Security findingsAdvisory findings (1)ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a94f498123
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b43b37f83c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
🛡️ Codex Security Review · Automatically triggered
Here are some automated security review suggestions for this pull request.
Reviewed commit: 927a4dea7e
ℹ️ About Codex security reviews in GitHub
This is an experimental Codex feature. Security reviews are triggered when:
- You comment "@codex security review"
- A regular code review gets triggered (for example, "@codex review" or when a PR is opened), and you’re opted in so security review runs alongside code review
Once complete, Codex will leave suggestions, or a comment if no findings are found.
Implements P0+P1 of
docs/design/execution-engine-managed-lifecycle.md: auto-discovery of existing engines and one-click managed installs.Discovery (P0): opening engine settings runs a read-only scan (PATH + well-known locations + command names), probes what it finds through the existing fail-closed installation probe, and each engine card offers "使用检测到的 " to adopt the detected path into the profile draft. Nothing is written to the user's global environment.
Managed install (P1): for Codex and Claude Code, an Install button downloads the pinned platform package from npm, verifies the registry sha512 integrity, extracts atomically under
~/.ling-stack/engines/<engine>/<version>/with a marker receipt, probes the binary, and opens the prefilled profile draft for confirmation. Kimi/OpenClaw keep manual guidance (their distribution channels are not npm-verified yet).Surface: new daemon routes
GET /execution-engines/discoveryandPOST|GET /execution-engines/<id>/installbehind the existing management authority; shared through api-client and the desktop IPC bridge; 55 locales translated.Evidence: 8 daemon unit/route tests; real-daemon Playwright spec with screenshot at
docs/design/ui2.0升级/evidence/settings/execution-engines/1440x960-engine-discovery-en-US.png(all four engines detected on a machine that has them installed).P2 (authorized in-place takeover) and P3 (update detection prompts) follow in later PRs per the plan.