Repository navigation
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
ca41a80 to
2d2dd20
Compare
2d2dd20 to
074cf62
Compare
gansx
changed the title
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 074cf624f3
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| "lucide-react": "1.61.0", | ||
| "qrcode": "1.5.4", | ||
| "react": "^19.2.8", | ||
| "react": "^19.3.1", |
There was a problem hiding this comment.
The web app now resolves react@19.3.1, but the committed lockfile still resolves react-dom@19.3.0(react@19.3.1). CI and release workflows install with --frozen-lockfile, so browser builds will run with mismatched React/ReactDOM versions; React requires these packages to have the exact same version and reports an incompatibility at runtime. Update the ReactDOM dependency and lockfile for the browser-facing packages (while handling the separate Expo constraint for mobile).
Useful? React with 👍 / 👎.
|
排查结论：#592 的 e2e 失败根因不是 react 19.3.1 本身，而是版本错位——Dependabot 只升了 react（19.3.1）而 react-dom 留在 19.3.0，错位组合让 Linux e2e 点击超时（3/3 复现）。对齐到 19.3.1/19.3.1 后 e2e 全过，但 Expo SDK 58 把 react 和 react-dom 都钉死在 19.3.0，对齐升级会挂 Expo 兼容测试。结论：react 保持 19.3.0，等 Expo SDK 支持 19.3.1 后一起升；两个包以后必须同时升，不允许单独升 react。 |
Supersedes #592. react 19.3.0 → 19.3.1 only; react-dom stays at 19.3.0 because apps/mobile's Expo SDK compatibility test pins it. The earlier e2e failures on #592 do not reproduce on current main: the Linux production Web QA step passes with 19.3.1.