Repository navigation
feat(web): simplify normal conversation composer controls - #584
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The normal conversation footer had separate model, reasoning, summary, authorization, and sandbox controls. It now exposes three approval shortcuts beside the input—Request approval, Help me approve, and Full access—and combines model selection and reasoning strength in one popover. The slider fill follows the rounded thumb.
Independent authorization and sandbox defaults remain in Settings. Request approval and Help me approve preserve the sandbox. Full access changes both axes only after explicit confirmation; cancel preserves both, and switching back restores the previous sandbox (or the workspace default after reopening). Inherited always authorization with a restricted sandbox is displayed accurately. Confirmation state stays in the compact button's accessible name and tooltip.
Validation
59735aa76d4e8ba94a51f82da4bf835d83d0fe99: all 15 checks passed, including the required aggregate, all four Daemon shards, Linux contracts, and the real macOS helper/Seatbelt smoke. CI run: https://github.com/ling-stack-org/ling-stack/actions/runs/39954759834Broader timeline-anchor remeasurement checks have an existing failure: both variants also fail at the same assertion in a separate, unmodified checkout of the current main revision. These test cases and timeline implementation remain unchanged; the failures are retained in the local validation record. No assertion or timeout was relaxed.
Review and compatibility
Parent and native adversarial source reviews found no actionable issue; the native pass reviewed test/fixture changes in summary mode. Documentation review confirmed the updated composer and full-access contracts. Outside-provider review was not completed.
Reasoning-summary workspace defaults and restored values still reach outgoing requests. Configuration remains workspace-scoped; no application-wide settings backend, web-search/output-detail options, API/schema, provider runtime, or native platform changes are introduced. The Alpha version is unchanged, with an Unreleased changelog entry. This PR does not deploy or restart the installed application.