Repository navigation
feat(desktop): preview local file links with native open actions - #583
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Desktop conversation paths now open in the existing right drawer: UTF-8 text/code with line numbers, raster images, and bounded folder browsing. Unsupported files such as ZIPs keep an actionable placeholder, while right-click and Open with expose native application choices, Save as, copy and file-manager actions.
Scope
docs/design/conversation-shared-capabilities.md#desktop-local-file-viewing.Validation
The selected-package runner additionally passed core (3608), contracts (90), API client (107), browser host (18), conversation React (26), providers (74), and remote protocol (40) tests. Its initial local remote-client step lacked dist outputs; the declared build-and-test command then passed all nine tests. Web was rerun afterward and passed 575/575.
The browser journey uses a desktop bridge fixture; a separate real Electron smoke verifies trusted clicks, synthetic-click rejection, ZIP inspection and native menu construction. macOS ZIP associations returned Archive Utility, Keka and WorkBuddy. No external application is launched by the smoke.
Product And Visual Evidence
Retained locally under
output/playwright/local-files/:code-dark.png(highlighted line and complete code drawer) andzip-dark.png(unsupported placeholder and Open with). Final captures use the app's reduced-motion preference for stable layout. Normal-motion keyboard, directory, failure and latest-selection behavior passed the journey tests. Light-theme and actual Windows/Linux chooser acceptance were not run.Risk And Compatibility
No storage migration, provider or public daemon API change; no new dependencies. Local viewing does not add file contents to AI context or authorize tools. Text previews cap content at 256 KiB and show a 300-line window; images cap at 10 MiB and folder listings at 500 entries. PDF/Office/archive/binary preview remains unsupported with external actions available. macOS is runtime-verified; Windows/Linux external-app chooser behavior still needs platform acceptance.
Native defensive and frontend/coverage reviews have no confirmed unresolved defect after the UNC-cwd rejection fix. Optional external Claude Code review was unavailable due to authentication; it is not counted as passing coverage. Gate scan: four test hunks listed, no eligible relaxations. Extra scenarios not directly asserted in new E2E include chat-switch invalidation, competing drawer navigation, parent-root boundaries and image rendering.
Documentation
Local-viewing limits and user actions are documented in shared capabilities and linked from the desktop-shell and right-dock contracts. The feature contracts were audited before the final locale-only completion; those original contract inputs are unchanged. The subsequent 53 catalog data files received structural review across all locales and linguistic sampling of eight locales. Standalone newcomer tutorial remains documentation debt; no affected diagram drift.
Checklist