Repository navigation
feat(workspace): unify work summary and show changes in the right drawer - #580
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The existing Summary entry now combines environment/context information with project sessions, net Git changes, recent commits, and linked PRs. Clicking a change row opens the current conversation's existing right review drawer at the selected workspace, preserving the chat page.
WorkspaceClientView.tsxnow delegates its types, environment loading, local panel navigation, header, and overlay composition to adjacent modules. Message, send, approval, and feedback ownership remain in their existing controllers.Scope
baseline=headis supplied. No dependency, version, release-tag, or deployment changes.Validation
89f340e2: all 15 GitHub checks passed, including Core/Web unit checks, four daemon shards, typecheck, build, security, CodeQL and native macOS/Linux checks. Markdown links, whitespace, public-repository safety and credential checks completed.Product And Visual Evidence
Manual Electron acceptance at 1440×920 confirmed the unified right-side summary and the existing review drawer with two real changed files and +3/−1. The private-chat path also opened its existing drawer; no dialog or renderer error appeared. Viewport bounds, scrolling, retained context and duplicate counts were inspected. Screenshots are retained locally as
unified-summary-desktop.png,changes-right-drawer-desktop.pngandprivate-changes-right-drawer-desktop.png. Follow-up Electron screenshotsopen-menu-top-desktop.pngandopen-menu-bottom-desktop.pngshow every available opener and Download, with pointer-hit checks on all entries. At the native minimum window size (980×680), a bottom file menu flipped upward, all six entries remained reachable, and the renderer reported no errors (open-menu-bottom-small-desktop.png); screenshots are not uploaded by this PR.Automated panel suites cover light/dark and reduced motion. Live GitHub account access and packaged/signed distribution were not exercised.
Pre-Landing Review
Native source review found no remaining actionable issues after fixing session-surface classification, binary detail retention, and truncated owner lookup. Tests/fixtures were reviewed by that adversarial reviewer in summary mode. The parent verified actual test runs and desktop behavior.
Gate scan: 42 hunks listed, all 37 eligible hunks read, no weakening finding. Summary locators now select the exact existing entry; the environment regression asserts the single net-change row and absence of the superseded duplicate. Native code/design reviews passed. The optional external Claude Code review was unavailable because authentication failed; it is not counted as completed. The native design detector was unavailable; the local script and manual visual inspection were used.
Follow-up review fixed
content-visibilitypaint clipping while a file menu is open, placed upward menus above the sticky toolbar, and made height-limited menus scroll. Tests first reproduced the clipping and pointer failures. CI also exposed a migration-number collision with the existing native effect inventory migration; work summary now owns 176, and the legacy upgrade fixture retains its historical schema/row assertions while explicitly checking the new overlay.Risk And Compatibility
Summary routes retain local Origin/trusted-workspace checks and never initialize another project store. GitHub requests accept canonical github.com PR URLs, use a fixed API host with redirects disabled, and bind CI to the current head SHA. PR status requires an existing GITHUB_TOKEN or GH_TOKEN; without one, links remain usable and status is unconnected. Other locales retain existing translations and fall back to English for new untranslated messages.
The original checkout's unrelated WIP is outside this branch. This is a feature PR, with the repository's existing alpha version preserved; the generic ship version classifier does not support that prerelease format.
Documentation
Status: current — 最终文档重审通过;后续仅同步 SQLite migration 176 的编号,版本一致性阻断已解除。
审计范围:最终候选的统一摘要入口、当前会话右侧审查抽屉、显式 cwd 与 baseline=head、Git 净统计与共享 worktree、PR 本地关联和当前 SHA 状态、WorkspaceClientView 模块拆分、语言登记与旧 channel 回归修复。复用初审 10 份文档的完整阅读,并核验其当前内容 hash;补齐 CHANGELOG 与发布版本只读核对。
Documentation health:
README.md [Current] (工作摘要入口链接保留)
README.zh-CN.md [Current] (统一摘要和右侧审查入口说明一致)
CONTRIBUTING.md [Current] (开发与验证流程未变,文件与 HEAD 一致)
CHANGELOG.md [Current] (Unreleased 条目符合当前实现,最新已发布版本与包版本一致)
docs/architecture.md [Current] (共享客户端、daemon、SQLite 边界一致)
docs/design/README.md [Current] (工作摘要已纳入会话文档索引)
docs/features/work-summary.md [Current] (入口、API、限制、刷新、PR、模块职责和验证范围符合已审代码)
docs/design/conversation-right-dock-workspace-tools.md [Current] (无 Details 时的摘要 overlay 例外与实现一致)
docs/design/channel-environment-information-hierarchy.md [Current] (完整环境页的信息入口保留)
docs/design/conversation-right-dock-responsive-visibility-implementation-plan.md [Current] (Right Dock 原有宽度门槛保持一致)
docs/design/ui2.0升级/modules/04-会话界面.md [Current] (三种会话的共享职责保持一致)
Documentation coverage:
统一摘要与审查抽屉:reference、how-to、explanation 已覆盖;无完整 tutorial。
摘要与 PR 关联 API、baseline=head:reference 已覆盖;独立 API 调用 how-to 属于 reference-only debt。
Git 净统计、共享 worktree、读取限制:reference 与 explanation 已覆盖;无完整 tutorial。
GitHub token、当前 SHA CI、PR 持久化:reference 与简短 how-to 已覆盖;真实账号配置与权限排错教程仍是文档债务。
WorkspaceClientView 模块拆分:职责 reference 已覆盖;独立贡献者 walkthrough 仍是文档债务。
无完全零覆盖的新增能力;未生成额外页面。
Diagram drift: 高层架构与共享 RightDockShell 图实体保持有效;初审发现的 Summary 空间规则漂移已修正。Details 可见时的隐藏、预留和 hysteresis 规则,以及 900px 及以下 Right Dock 隐藏规则均保持原契约。
Checklist