Skip to content

fix(security): resolve CodeQL parsing alerts - #575

Merged
gansx merged 4 commits into
mainfrom
gansx/fix-codeql-security
Oct 23, 2026
Merged

gansx merged 4 commits into
mainfrom
gansx/fix-codeql-security

Conversation

@gansx

@gansx gansx commented Oct 21, 2026

Copy link
Copy Markdown
Collaborator

main still reports 36 CodeQL alerts in parsing and text-normalization paths: polynomial ReDoS, incomplete HTML tag filtering, and double escaping.

This change replaces the flagged regex paths with bounded linear scanners, centralizes one-layer HTML entity decoding, uses the existing YAML parser for skill front matter, and adds long-input and compatibility regressions. Existing parsing behavior is preserved for URLs, Markdown, report titles, workflow placeholders, model identifiers, MCP tool names, and link-body extraction.

Validation:

  • TypeScript checks passed for conversation-ui-core, core, daemon, and providers
  • Focused regression suites passed across conversation UI, core, providers, daemon, and TestSavant
  • Long malformed input/property comparisons passed
  • git diff --cached --check passed

After this PR runs, CodeQL must show no matching alerts and no new alerts before merge.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 21, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ⚠️ Failed 2026-10-21T02:03:16.568787Z
We couldn’t complete this review. Comment @codex review to try again.
0376bf8 PR opened
🔒 Security Review ⚠️ Failed 2026-10-23T00:49:24.176327Z
We couldn’t complete this review. Comment @codex security review to try again.
d71d185 New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@gansx
gansx merged commit f916d25 into main Oct 23, 2026
15 checks passed
@gansx
gansx deleted the gansx/fix-codeql-security branch October 23, 2026 01:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant