Skip to content

fix(web): show approvals in normal conversations - #462

Merged
tianxiaochannel-oss88 merged 1 commit into
mainfrom
codex/normal-conversation-approvals
Aug 25, 2026
Merged

tianxiaochannel-oss88 merged 1 commit into
mainfrom
codex/normal-conversation-approvals

Conversation

@tianxiaochannel-oss88

Copy link
Copy Markdown
Collaborator

Summary

  • Render pending approvals inside the normal conversation composer, matching channel behavior.
  • Support expanding additional approvals, opening approval details, and approving or denying from the composer.
  • Refresh the selected conversation after an approval is resolved so the card disappears immediately.

Verification

  • Playwright: normal conversation renders inline approvals and resolves them from the composer — 1 passed.
  • corepack pnpm --filter @ling-stack/web typecheck — passed.
  • corepack pnpm --filter @ling-stack/web lint — passed.
  • corepack pnpm --filter @ling-stack/web build — passed; existing large-chunk warning only.
  • git diff --check — passed.

Scope

  • 5 files changed, all limited to normal conversation approval projection, composer wiring, and regression coverage.
  • Existing untracked apps/desktop/release.* directories were not included.

@tianxiaochannel-oss88
tianxiaochannel-oss88 merged commit c73052f into main Aug 25, 2026
1 check passed
@tianxiaochannel-oss88
tianxiaochannel-oss88 deleted the codex/normal-conversation-approvals branch August 25, 2026 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant