Skip to content

Update the changelog for sparse strips renderers#1344

Merged
LaurenzV merged 1 commit into
mainfrom
bump
Jan 8, 2026
Merged

Update the changelog for sparse strips renderers#1344
LaurenzV merged 1 commit into
mainfrom
bump

Conversation

@LaurenzV

@LaurenzV LaurenzV commented Jan 7, 2026

Copy link
Copy Markdown
Collaborator

I've set the release date for tomorrow.

@LaurenzV LaurenzV requested review from DJMcNab and nicoburns January 7, 2026 21:50
Comment thread sparse_strips/vello_common/src/recording.rs
@LaurenzV

LaurenzV commented Jan 7, 2026

Copy link
Copy Markdown
Collaborator Author

I'll wait until tomorrow in case someone else wants to take a look. Perhaps #1329 and #1335 will be merged by then, but probably not a big deal if not.

@DJMcNab DJMcNab left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't reviewed the content, just given a first pass and found this issue.

As a small process note, I see that you've not updated the versions in the Cargo.toml files. That is correct, because this is the CHANGELOG update PR, but note that we also shouldn't be updating the version numbers in the CHANGELOG files either, until the actual release PR. That ensures that the changelog file on main accurately reflects the actual released/unreleased state of the commit. We should also probably change the title of this PR.
I'd also like to see a PR to make sure our dependencies are up-to-date before the release.

Remember that we have https://linebender.org/wiki/process/release/ documented. If anything in there is unclear, feel free to reach out to ask!

Comment thread sparse_strips/vello_common/CHANGELOG.md Outdated
@LaurenzV LaurenzV marked this pull request as draft January 7, 2026 22:02
@LaurenzV LaurenzV changed the title Version bump for sparse strips renderers Prepare new release for sparse strips renderers Jan 7, 2026
@LaurenzV LaurenzV marked this pull request as ready for review January 7, 2026 22:36
@LaurenzV

LaurenzV commented Jan 8, 2026

Copy link
Copy Markdown
Collaborator Author

I reverted the version bump in the changelog, as mentioned in the Zulip, I'm not sure what to do about the dependencies though. Should I just blindly update all of them, even if some aren't used by sparse strips?

@LaurenzV LaurenzV changed the title Prepare new release for sparse strips renderers Update the changelog for sparse strips renderers Jan 8, 2026
@LaurenzV LaurenzV requested a review from DJMcNab January 8, 2026 09:47

@DJMcNab DJMcNab left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! I've not done the check to see if there's anything else which should have been included.

@LaurenzV LaurenzV added this pull request to the merge queue Jan 8, 2026
Merged via the queue into main with commit a459eb2 Jan 8, 2026
17 checks passed
@LaurenzV LaurenzV deleted the bump branch January 8, 2026 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants